Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbeaver/pro#2574 Support nested rows in grid #33113

Merged
merged 14 commits into from
May 31, 2024

Conversation

ShadelessFox
Copy link
Member

@ShadelessFox ShadelessFox commented May 16, 2024

image

Nested values don't support editing.

@ShadelessFox ShadelessFox marked this pull request as draft May 16, 2024 12:47
@ShadelessFox ShadelessFox force-pushed the dbeaver/pro#2574-grid-nested-rows branch from a97640b to 4d64e12 Compare May 16, 2024 13:52
@ShadelessFox ShadelessFox marked this pull request as ready for review May 17, 2024 12:36
Copy link
Member

@E1izabeth E1izabeth left a comment

@Matvey16
Copy link
Member

Now bottom level objects in arrays have expand button that doesn't do anything. Is it expected?

dbeaver_bfokxSLqHQ.mp4

@Matvey16
Copy link
Member

The expand button disappeared from the grid cells in Dynamo, now it is shown only near row numbers
image

@ShadelessFox
Copy link
Member Author

Let's fix them in a separate ticket.

…er/pro#2574-grid-nested-rows

# Conflicts:
#	plugins/org.jkiss.dbeaver.ui.editors.data/src/org/jkiss/dbeaver/ui/controls/lightgrid/LightGrid.java
@Matvey16
Copy link
Member

I hope we can fix them sooner than later because if feel like it's a regression
https://github.com/dbeaver/pro/issues/2871

@serge-rider serge-rider merged commit 283862c into devel May 31, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants