Adjusts on text when the Upgrade to Gold is unavailable #5598
+31
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Personally i feel like it would better to implement a way of toggling upgrade membership purchase rather than hardcoding it like this one way or another |
As far as I could study the code, there is a toggle, but only the upgrade page were using the flag that states this, I just made the changes on Users and Posts pages to react to |
|
@nonamethanks @evazion is there any necessary changes to my PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the comment from unitooni on forum #21157 ,those commits are very straightforward, making some changes on the view when upgrade (a.k.a Gold) is unavailable.
Also (partially) Fixes #5265