-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page selection menu #5523
base: master
Are you sure you want to change the base?
Add page selection menu #5523
Conversation
Check if screen width is less than 660px or not inspire by css class .mobile-only
Yo man... you're going to want to squash this down to a single commit to have any hope of this ever being merged. |
Done. I'm kinda new to this may I ask why. Also I don't know if i should include b41563b or not |
Yeah, don't include b41563b. If any merging needs to be done, evazion can do it on his side. However, if there are any merge conflicts, then you'll have to resolve them yourself and update the commit. As for why this is done, it's cleaner and easier to follow. Basically, each commit should encapsulate one entire change to the system, whether it's a minor fix or a feature add. If a pull request has multiple new features and/or changes, then it's fine to break them up each of them up into their own separate commits. |
- also make current page number have click feedback.
Is this okay? |
For the Utility.isMobile = function () {
window.screen.width <= 660 || window.screen.height <= 660;
} I went and added a check for the height as well, since many of your newer devices have a screen height greater than 660, in which case it would falsely detect it as being a desktop when the user has the phone rotated horizontally. It's outside the scope of this PR, but the mobile CSS should probably be updated to reflect that as well. /**** Mobile-only CSS ****/
@media (max-width: 660px) and (max-height: 660px) { } |
As for screen height. There are a lot of place where |
related #5518
On mobile when click at the page number the page selection menu will show up. On desktop this menu can be trigger using ... button in pagination instead.
I also add Utility.isMobile to determine user platform based on screen size similar to css .mobile-only