Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl fix bacpacmodel #824

Merged
merged 17 commits into from
May 15, 2024

Conversation

Splaxi
Copy link
Collaborator

@Splaxi Splaxi commented May 14, 2024

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧

To be consistent with Export-D365BacpacModelFile, it should be named Repair-D365BacpacModelFile.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Approved verbs for PowerShell, Repair should be avoided. Maybe Edit-D365BacpacModelFile?

d365fo.tools/functions/repair-d365bacpacmodel.ps1 Outdated Show resolved Hide resolved
d365fo.tools/functions/repair-d365bacpacmodel.ps1 Outdated Show resolved Hide resolved
d365fo.tools/functions/repair-d365bacpacmodel.ps1 Outdated Show resolved Hide resolved
d365fo.tools/functions/repair-d365bacpacmodel.ps1 Outdated Show resolved Hide resolved
d365fo.tools/functions/repair-d365bacpacmodel.ps1 Outdated Show resolved Hide resolved
d365fo.tools/functions/repair-d365bacpacmodel.ps1 Outdated Show resolved Hide resolved
d365fo.tools/functions/repair-d365bacpacmodel.ps1 Outdated Show resolved Hide resolved
d365fo.tools/functions/repair-d365bacpacmodel.ps1 Outdated Show resolved Hide resolved
d365fo.tools/functions/repair-d365bacpacmodel.ps1 Outdated Show resolved Hide resolved
@Splaxi
Copy link
Collaborator Author

Splaxi commented May 15, 2024

@FH-Inway

  • It seems that we have a good PR here. Ready for testing. Awaiting your feedback - before moving on.

@Splaxi Splaxi closed this May 15, 2024
@Splaxi Splaxi reopened this May 15, 2024
@FH-Inway FH-Inway merged commit 799f3da into d365collaborative:development May 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants