Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytest, fixes for recent python, add FTP tests #13661

Closed
wants to merge 5 commits into from
Closed

pytest, fixes for recent python, add FTP tests #13661

wants to merge 5 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented May 15, 2024

Fixes:

  • in uds tests, abort also silently on os errors
  • be conservative on the h3 goaway duration
  • detect curl debug build and use in checks
  • fix caddy version check for slight difference under linux
  • set caddy default path fitting for linux
  • fix deprecation warnings in valid time checks

FTP tests:

  • add '--with-test-vsftpd=path' to configure
  • use vsftpd default path suitable for linux
  • add test_30 with plain FTP tests
  • add test_31 with --ssl-reqd FTP tests
  • add vsftpd to linux GHA for pytest workflows

@github-actions github-actions bot added tests CI Continuous Integration labels May 15, 2024
@icing icing added the FTP label May 15, 2024
@dfandrich
Copy link
Contributor

dfandrich commented May 15, 2024 via email

@icing
Copy link
Contributor Author

icing commented May 15, 2024

Shouldn't the ftp tests go into a new "tests/ftp/" directory? It's unexpected seeing ftp tests in a directory called "http".

That would be one idea. Or rename http to something else.

@bagder
Copy link
Member

bagder commented May 15, 2024

I think the rustls.c fixes should be put into a separate PR to keep this one limited to the test suite.

@icing
Copy link
Contributor Author

icing commented May 16, 2024

I think the rustls.c fixes should be put into a separate PR to keep this one limited to the test suite.

Done in #13670.

icing added 5 commits May 17, 2024 10:09
@icing
pytest, fixes for recent python, add FTP tests
355259f 
Fixes:
- in uds tests, abort also silently on os errors
- be conservative on the h3 goaway duration
- detect curl debug build and use in checks
- fix caddy version check for slight difference under linux
- set caddy default path fitting for linux
- fix deprecation warnings in valid time checks

FTP tests:
- add '--with-test-vsftpd=path' to configure
- use vsftpd default path suitable for linux
- add test_30 with plain FTP tests
- add test_31 with --ssl-reqd FTP tests
- add vsftpd to linux GHA for pytest workflows
@icing
- add vsftpd to the spellcheck words
f16af33 
- fix rustls errors from CURLE_READ_ERROR to CURLE_RECV_ERROR
- exclude some tests on h3 if not available in curl
@icing
fix test_05_04 expectations depending on openssl and debug use
dff6da4
@icing
disable vsftpd requiring ssl session reuse
c2945dd
@icing
pytest, skip rustsls vsfpts tests because unreliable
8e7153a
@bagder
Copy link
Member

bagder commented May 17, 2024

I propose tests/pytests as a new name, but done in a separate PR.

@bagder bagder closed this in 3455572 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous Integration FTP tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@icing @dfandrich @bagder