Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Freiren holding python book #654

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add Freiren holding python book #654

wants to merge 2 commits into from

Conversation

jeoooo
Copy link
Contributor

@jeoooo jeoooo commented Jan 24, 2024

Girl: Freiren

Anime: Frieren: Beyond Journey's End

image

@cat-milk
Copy link
Owner

Could you capitalize the words "holding" and "book" in filename so that this matches the filename format in this repo?
I can merge it once you do that.

cat-milk
cat-milk requested changes Mar 23, 2024
View reviewed changes
Copy link
Owner

@cat-milk cat-milk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my other comment

@cat-milk cat-milk added the Bad filename The filename doesnt match the repo style or just isnt descriptive label Mar 23, 2024
@jeoooo jeoooo requested a review from cat-milk March 29, 2024 13:43
@jeoooo
Copy link
Contributor Author

jeoooo commented Mar 29, 2024

Could you capitalize the words "holding" and "book" in filename so that this matches the filename format in this repo? I can merge it once you do that.

@cat-milk hi !

i've updated the filename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cat-milk cat-milk Awaiting requested review from cat-milk

Assignees
No one assigned
Labels
Bad filename The filename doesnt match the repo style or just isnt descriptive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeoooo @cat-milk