-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add anime girl read Java book #546
base: master
Are you sure you want to change the base?
Conversation
I think you need to rename these files to reflect what the recommended filename structure. That last one, "Read_Anime.png" is clearly Patchouli Knowledge from the Touhou series. It wouldn't be hard for you to even run SauceNao to have it identify the artworks. Make it less painful for the pull request reviewers. |
Sorry, but out of 6 photos, I found the original source with only 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these but if possible could you try to add character names to some more of these?
If you don't know the names you can just use Unknown_${bookDetails}
and if you know for a fact that the character is simply unnamed (like in the case of some artist ocs) you can just use Unnamed_${bookDetails}
.
@fI0ki I'm bumping this in case you're still interested in getting this merged. This PR has been open for a year and a half so I'm going to assume you aren't keeping track of it anymore if I don't hear back by the time I check on this repo again (probably like a month or two from now given my track record lol) |
No description provided.