Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anime girl read Java book #546

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

rusIand
Copy link

@rusIand rusIand commented Oct 22, 2022

No description provided.

@SoftwareGuy
Copy link

I think you need to rename these files to reflect what the recommended filename structure.

That last one, "Read_Anime.png" is clearly Patchouli Knowledge from the Touhou series. It wouldn't be hard for you to even run SauceNao to have it identify the artworks.

Make it less painful for the pull request reviewers.

@rusIand
Copy link
Author

rusIand commented Oct 24, 2022

Sorry, but out of 6 photos, I found the original source with only 1

Copy link
Owner

@cat-milk cat-milk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these but if possible could you try to add character names to some more of these?

If you don't know the names you can just use Unknown_${bookDetails} and if you know for a fact that the character is simply unnamed (like in the case of some artist ocs) you can just use Unnamed_${bookDetails}.

@cat-milk cat-milk added the Who is this girl Need help identifying girl label Mar 8, 2023
@cat-milk cat-milk added the Bad filename The filename doesnt match the repo style or just isnt descriptive label Mar 23, 2024
@cat-milk
Copy link
Owner

@fI0ki I'm bumping this in case you're still interested in getting this merged. This PR has been open for a year and a half so I'm going to assume you aren't keeping track of it anymore if I don't hear back by the time I check on this repo again (probably like a month or two from now given my track record lol)

@cat-milk cat-milk added the Will be closed soon This PR has been inactive for a while and will be closed soon label Mar 23, 2024
Trol326 added a commit to Trol326/Anime-Girls-Holding-Programming-Books that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bad filename The filename doesnt match the repo style or just isnt descriptive Who is this girl Need help identifying girl Will be closed soon This PR has been inactive for a while and will be closed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants