Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Elma reading an object oriented programming book #404

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add Elma reading an object oriented programming book #404

wants to merge 8 commits into from

Conversation

VoidNakamura
Copy link

S1EP12 Elma from Dragon Maid is reading an object oriented programming book.

image
image

@hdk5
Copy link
Contributor

hdk5 commented Mar 29, 2022

You could use a better release

0x539 Miss Kobayashi's Dragon Maid - S01E12 (BD 1080p x264 Hi10P FLAC) F71ECE7E mkv_002128 764

0x539 Miss Kobayashi's Dragon Maid - S01E12 (BD 1080p x264 Hi10P FLAC) F71ECE7E mkv_002127 426

@Kholodets
Copy link
Collaborator

huh? did you use the wrong commit? this is all web viewer stuff
@VoidNakamura also the version hdk5 suggested is a but cleaner

@cat-milk
Copy link
Owner

If you could rebase this to be based on master I'll merge it

@cat-milk
Copy link
Owner

Also plus one on the slightly cleaner English version if you're up to the task

@github-pages github-pages bot temporarily deployed to github-pages April 17, 2022 21:55 Inactive
@hdk5 hdk5 mentioned this pull request May 13, 2022
Closed
@wheremyfoodat
Copy link
Contributor

wheremyfoodat commented Jan 19, 2024 •
edited

This is a very important PR and it not being merged interferes heavily with my workflow. Can we get an update and rebase on it?

@cat-milk
Copy link
Owner

This is a very important PR and it not being merged interferes heavily with my workflow. Can we get an update and rebase on it?

No because merging it would merge the gh pages branch with the web viewer code in it into the main branch

@cat-milk
Copy link
Owner

CANNED COPY PASTE REPLY:
This PR has been open for a while and has had requested changes that haven't been addressed. I'm going to close this PR if I don't at least hear back in the next month or two

@cat-milk cat-milk added the Will be closed soon This PR has been inactive for a while and will be closed soon label Mar 23, 2024
@cat-milk
Merge pull request #664 from cat-milk/master
ecf3d69 
Merge master into web/dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid Needs Rebase Will be closed soon This PR has been inactive for a while and will be closed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@VoidNakamura @hdk5 @Kholodets @cat-milk @wheremyfoodat