Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Metadata.json #276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

stuffedmeow
Copy link

@stuffedmeow stuffedmeow commented Dec 11, 2021

Metadata on featured series in JSON format, up to date 12/11/2021. Created in regards to Issue #245

To find the series that the anime girl is from, just CTRL + F the file name.

Metadata on featured series, up to date 12/11/2021
@Asday
Copy link

Asday commented Dec 11, 2021

This seems unmaintainable tbh. JSON is kinda a crappy format for human editing, and it's in one file rather than next to the images, so it's REALLY easy for it to get out of date.

@wizard-28
Copy link
Contributor

How about creating a CLI that modifies the metadata file when someone adds a pic. So that humans don't have to edit it manually.

@cat-milk
Copy link
Owner

How about creating a CLI that modifies the metadata file when someone adds a pic. So that humans don't have to edit it manually.

I have actually been considering setting up some pre-commit hooks to validate filenames so setting it up to also add those file names to a meta-data file wouldn't be much extra work from my understanding.
Though having a meta-data file that keeps track of what series a girl is from or even just keeps track of her name would present some challenges for adding girls who are just some random artists OC. We'd also might want to reconsider our file naming pattern if were going to try to introspect that data from the files themselves.

If were fine with adding the data manually maybe we could require that the meta-data be included with every file added and then just have the commit hook verify that all the files in the commit have corresponding meta-data entry.

@cat-milk
Copy link
Owner

This issue seems relevant to this PR so Im just going to link them to each other
#285

@cat-milk cat-milk mentioned this pull request Feb 21, 2022
@milesfromcali
Copy link

Merge the 2 codes that let you choose the girls and modify at the same time

@cat-milk cat-milk mentioned this pull request Mar 2, 2022
@IAMSolaara
Copy link

Perfect chance to do this through GH Actions

@Akronymus-git
Copy link
Contributor

Wouldn't it make more sense to use a series of tags, rather than an hierachical structure?

@Anatoly03
Copy link

A year later I'd like to add my coin to the pig. Would it not make sense to instead write a metadata generator? This fixes the maintenance problem adressed above.

The program could act like this: Scan all images -> Take the first word before the _ (Ram_Holding_JavaScript_The_Good_Parts.png would become Ram), then search for Ram Anime, wether with the google api, wikipedia or another (anime-specific?) library, find anime name and get the meta from it.

Long-term better Alternative: Rename all files to $ANIME_$CHARACHTER_$DESCRIPTION and just google $ANIME instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants