Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Reimi Sugimoto Clean Code #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Reimi Sugimoto Clean Code #219

wants to merge 1 commit into from

Conversation

Vsev0l0d
Copy link

@Vsev0l0d Vsev0l0d commented Jul 8, 2021

Jojo's Reimi Sugimoto with "Clean Code: A Handbook of Agile Software Craftsmanship (Robert C. Martin) (Robert C. Martin Series)"

@Vsev0l0d
Reimi Sugimoto
b32684b 
Jojo's Reimi Sugimoto with "Clean Code: A Handbook of Agile Software Craftsmanship (Robert C. Martin) (Robert C. Martin Series)"
@cat-milk
Copy link
Owner

something about this image feels off. I think its the perspective on the book

@kotx
Copy link

kotx commented Oct 15, 2021

something about this image feels off. I think its the perspective on the book

yeah, the left hand is in front of the book which is weird

@cat-milk cat-milk self-requested a review November 11, 2021 17:15
cat-milk
cat-milk requested changes Nov 11, 2021
View reviewed changes
Copy link
Owner

@cat-milk cat-milk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image needs a little bit of perspective work to make it look right but I'd be happy to merge it once thats done.

@cat-milk cat-milk added help wanted Image needs work It doesn't look quite right labels Nov 11, 2021
@Treppenhaus Treppenhaus mentioned this pull request Mar 1, 2022
Closed
@cat-milk
Copy link
Owner

@Vsev0l0d

CANNED COPY PASTE REPLY:
This PR has been open for a while and has had requested changes that haven't been addressed. I'm going to close this PR if I don't at least hear back in the next month or two

@cat-milk cat-milk added the Will be closed soon This PR has been inactive for a while and will be closed soon label Mar 23, 2024
@Supercolbat
Copy link

Hello, this PR appeared on my front page, so I figured I might have a go at it. Here's my suggested edit. Evidently, the original image isn't holding a book, so it will look slightly off.

The hash of this uploaded image and my local copy are the same, so no weird compression stuff.

Expand image Java/Reimi_Sugimoto_Clean_Code.png

@akirataguchi115
Copy link

This PR appeared on my feed as well. Supercolbat's version looks good to me! ❤️

Trol326 added a commit to Trol326/Anime-Girls-Holding-Programming-Books that referenced this pull request Mar 26, 2024
@Trol326
add reimi sugimoto from Vsev0l0d's PR cat-milk#219 edit by Supercolbat
0879885
@Trol326 Trol326 mentioned this pull request Mar 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cat-milk cat-milk cat-milk requested changes

@bjvanbemmel bjvanbemmel bjvanbemmel approved these changes

Assignees
No one assigned
Labels
help wanted Image needs work It doesn't look quite right Will be closed soon This PR has been inactive for a while and will be closed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Vsev0l0d @cat-milk @kotx @Supercolbat @akirataguchi115 @bjvanbemmel