Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app crash on accessing certains pages of organization/teams when user not part of any organization or team #15106

Merged
merged 3 commits into from
May 21, 2024

Conversation

Shaik-Sirajuddin
Copy link
Contributor

What does this PR do?

Before :
#15061 (comment)
After :
https://www.loom.com/share/292fdf3986384eaab63e562c1a81ec94?sid=e5c90ebd-c266-4f5c-948b-00aed0194025

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Login using account , not enrolled is an organization or present in a team
  • Visit pages of organization and teams
    /settings/teams/4/members
    /settings/teams/4/profile
    /settings/teams/4/appearance
    /settings/organizations/profile
    /settings/organizations/appearance
  • User will be redirected to enterprise or teams page based on initially requested page
  • App crashes before the fix

Checklist

Copy link

vercel bot commented May 18, 2024

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label May 18, 2024
@graphite-app graphite-app bot requested a review from a team May 18, 2024 09:22
Copy link
Contributor

github-actions bot commented May 18, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added teams area: teams, round robin, collective, managed event-types 🐛 bug Something isn't working labels May 18, 2024
@dosubot dosubot bot added the organizations area: organizations, orgs label May 18, 2024
Copy link

graphite-app bot commented May 18, 2024

Graphite Automations

"Add community label" took an action on this PR • (05/18/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@Shaik-Sirajuddin Shaik-Sirajuddin changed the title change redirect location for teams and organization pages fix: app crash on accessing certains pages of organization/teams when user not part of any organization or team May 18, 2024
Copy link
Contributor

github-actions bot commented May 18, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution; much appreciated. I do wonder why the app crash is so slow but this is not important.

@emrysal emrysal enabled auto-merge (squash) May 20, 2024 13:55
@Shaik-Sirajuddin
Copy link
Contributor Author

Thank you for your contribution; much appreciated. I do wonder why the app crash is so slow but this is not important.

Thank you emrysal for review!
The speed might slightly be improved migrating to getServerSideProps for server side routing.
Currently Client side routing is being used in around 9 pages , related to this specific issue

@keithwillcode keithwillcode added this to the v4.2 milestone May 20, 2024
@emrysal emrysal merged commit a4a1c01 into calcom:main May 21, 2024
33 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync organizations area: organizations, orgs teams area: teams, round robin, collective, managed event-types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access certain pages of team / organization pages with no access crashes app
3 participants