refactor: v2 API event-types #15096
Draft
refactor: v2 API event-types #15096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
keithwillcode
added
core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Eighty-two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 313 Passing - ❌ 3 Failing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/17/2024 05:23:02pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 5821ee0 Started: 05/17/2024 05:16:14pm UTC ❌ Failures📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 FailureTest Case Results
📄 apps/web/playwright/event-types.e2e.ts • 1 FailureTest Case Results
📄 apps/web/playwright/teams.e2e.ts • 1 FailureTest Case Results
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Pending payment booking should not be confirmed by default
Retry 1 • Initial Attempt |
3.08% (7)7 / 227 runsfailed over last 7 days |
17.18% (39)39 / 227 runsflaked over last 7 days |
|
Stripe integration Paid booking should be able to be cancelled
Retry 1 • Initial Attempt |
2.25% (5)5 / 222 runsfailed over last 7 days |
13.06% (29)29 / 222 runsflaked over last 7 days |
📄 apps/web/playwright/managedBooking/advancedOptions.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Check advanced options in a managed team event type Check advanced options in a managed team event type without offer seats
Retry 1 • Initial Attempt |
0.41% (1)1 / 242 runfailed over last 7 days |
47.52% (115)115 / 242 runsflaked over last 7 days |
📄 apps/web/playwright/manage-booking-questions.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Manage Booking Questions For User EventType Do a booking with a Address type question and verify a few thing in b/w
Retry 1 • Initial Attempt |
2.50% (6)6 / 240 runsfailed over last 7 days |
1.67% (4)4 / 240 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- legacy login flow user & logout using dashboard
Retry 1 • Initial Attempt |
0% (0)0 / 240 runsfailed over last 7 days |
18.75% (45)45 / 240 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user can add multiple organizer address
Retry 1 • Initial Attempt |
1.62% (4)4 / 247 runsfailed over last 7 days |
21.05% (52)52 / 247 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can resend verification link if the secondary email is unverified
Retry 1 • Initial Attempt |
12.64% (35)35 / 277 runsfailed over last 7 days |
29.96% (83)83 / 277 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0.83% (2)2 / 240 runsfailed over last 7 days |
32.50% (78)78 / 240 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load if correct embedLibUrl is provided
Retry 1 • Initial Attempt |
0% (0)0 / 233 runsfailed over last 7 days |
32.62% (76)76 / 233 runsflaked over last 7 days |
📄 packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 1 • Initial Attempt |
15.04% (37)37 / 246 runsfailed over last 7 days |
36.18% (89)89 / 246 runsflaked over last 7 days |
supalarry
force-pushed
the
lauris/cal-3581-apiv2-geteventtype-endpoint-should-be-client-agnostic
branch
from
6c00d30
to
9359037
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist