Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #15045 #15094

Closed
wants to merge 3 commits into from
Closed

Fix: #15045 #15094

wants to merge 3 commits into from
+175 −5,374

Conversation

deepak-singh19
Copy link

This PR addresses the issue where the "Terms" link was not rendering in the UI and fixes a linting error due to missing key props in the Trans component from react-i18next.

Changes Made

  1. Issue with "Terms" Not Rendering:

The "Terms" link was not appearing correctly in the UI.
Updated the Trans component structure to ensure proper rendering of both "Terms" and "Privacy Policy" links in both BookEventForm.tsx and signup.tsx

  1. Linting Error:

Added key props to the Link elements within the components array to resolve the linting error (Missing "key" prop for element in array react/jsx-key).

Screenshot 2024-05-17 at 9 06 19 PM

@vercel Vercel
Copy link

vercel bot commented May 17, 2024

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label May 17, 2024
@graphite-app graphite-app bot requested review from a team May 17, 2024 15:39
@CLAassistant
Copy link

CLAassistant commented May 17, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "Fix" found in pull request title "Fix: #15045". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added i18n area: i18n, translations ui area: UI, frontend, button, form, input labels May 17, 2024
@socket-security Socket Security
Copy link

socket-security bot commented May 17, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@aashutoshrathi/word-wrap@1.2.6 None 0 10.9 kB aashutoshrathi
npm/@babel/helper-environment-visitor@7.22.20 None 0 6.56 kB nicolo-ribaudo
npm/@babel/regjsgen@0.8.0 None 0 15.4 kB nicolo-ribaudo
npm/@bcoe/v8-coverage@0.2.3 None 0 277 kB bcoe
npm/@calcom/baa-for-hipaa@0.0.0-use.local None 0 0 B
npm/@eslint-community/regexpp@4.10.0 None 0 431 kB eslint-community-bot
npm/@humanwhocodes/module-importer@1.0.1 unsafe 0 21.2 kB nzakas
npm/@istanbuljs/schema@0.1.3 None 0 17.2 kB coreyfarrell
npm/@nodelib/fs.stat@2.0.5 filesystem 0 11.8 kB mrmlnc
npm/@protobufjs/aspromise@1.1.2 None 0 9.05 kB dcode
npm/@protobufjs/base64@1.1.2 None 0 9.22 kB dcode
npm/@protobufjs/codegen@2.0.4 None 0 9.14 kB dcode
npm/@protobufjs/eventemitter@1.1.0 None 0 7.75 kB dcode
npm/@protobufjs/float@1.0.2 None 0 27 kB dcode
npm/@protobufjs/inquire@1.1.0 None 0 4.29 kB dcode
npm/@protobufjs/path@1.1.2 None 0 7.77 kB dcode
npm/@protobufjs/pool@1.1.0 None 0 6.25 kB dcode
npm/@protobufjs/utf8@1.1.0 None 0 23.5 kB dcode
npm/@sinclair/typebox@0.27.8 None 0 442 kB sinclair
npm/@tsconfig/node12@1.0.11 None 0 2.5 kB typescript-deploys
npm/@tsconfig/node14@1.0.3 None 0 2.39 kB typescript-deploys
npm/@tsconfig/node16@1.0.4 None 0 2.45 kB typescript-deploys
npm/@typescript-eslint/visitor-keys@6.19.0 None 0 19.3 kB jameshenry
npm/@ungap/structured-clone@1.2.0 None 0 26.2 kB webreflection
npm/acorn-walk@8.2.0 None 0 42.8 kB marijn
npm/ansi-colors@4.1.3 environment 0 26.1 kB jonschlinkert
npm/ansi-regex@6.0.1 None 0 5.67 kB qix
npm/array-union@2.1.0 None 0 3.17 kB sindresorhus
npm/assert-plus@1.0.0 environment 0 11.4 kB pfmooney
npm/aws-sign2@0.7.0 None 0 14.2 kB mikeal
npm/aws4@1.12.0 environment 0 23.5 kB hichaelmart
npm/base64-js@1.5.1 None 0 9.62 kB feross
npm/before-after-hook@2.2.3 None 0 37 kB gr2m
npm/bignumber.js@9.1.2 None 0 351 kB mikemcl
npm/bottleneck@2.19.5 eval 0 629 kB sgrondin
npm/buffer-crc32@0.2.13 None 0 7.95 kB brianloveswords
npm/callsites@3.1.0 None 0 6.33 kB sindresorhus
npm/camelcase@5.3.1 None 0 7.45 kB sindresorhus
npm/caseless@0.12.0 None 0 14.3 kB mikeal
npm/char-regex@1.0.2 None 0 4.96 kB richienb
npm/chardet@0.7.0 filesystem 0 74.8 kB runk
npm/ci-info@3.9.0 environment 0 26.1 kB sibiraj-s
npm/cli-width@3.0.0 environment 0 11.5 kB knownasilya
npm/clone@1.0.4 None 0 11.1 kB pvorb
npm/co@4.6.0 None 0 16 kB jongleberry
npm/color-name@1.1.3 None 0 9.36 kB dfcreative
npm/colorette@2.0.20 None 0 17 kB jorgebucaran
npm/convert-source-map@2.0.0 None 0 15.9 kB phated
npm/core-util-is@1.0.2 None 0 23.2 kB isaacs
npm/crc-32@1.2.2 None 0 31 kB sheetjs
npm/create-require@1.1.1 filesystem, unsafe 0 6.25 kB pi0
npm/crypto-random-string@2.0.0 None 0 3.93 kB sindresorhus
npm/deep-extend@0.6.0 None 0 9.19 kB unclechu
npm/deep-is@0.1.4 None 0 8.11 kB thlorenz
npm/deepmerge@4.3.1 None 0 31.2 kB tehshrike
npm/deprecation@2.3.1 None 0 4.01 kB gr2m
npm/detect-indent@6.1.0 None 0 9.68 kB sindresorhus
npm/detect-newline@3.1.0 None 0 3.77 kB sindresorhus
npm/diff-sequences@29.6.3 None 0 46 kB simenb
npm/diff@4.0.2 None 0 335 kB kpdecker
npm/eastasianwidth@0.2.0 None 0 13.6 kB komagata
npm/emittery@0.13.1 None 0 46.5 kB sindresorhus
npm/emoji-regex@9.2.2 None 0 97.9 kB google-wombot
npm/escape-string-regexp@1.0.5 None 0 2.69 kB jbnicolai
npm/eslint-visitor-keys@3.4.3 None 0 32.3 kB eslintbot
npm/esprima@4.0.1 None 0 314 kB ariya
npm/esutils@2.0.3 None 0 50.6 kB michaelficarra
npm/eventemitter3@4.0.7 None 0 38 kB lpinca
npm/exit@0.1.2 None 0 59.8 kB cowboy
npm/extend@3.0.2 None 0 23.5 kB ljharb
npm/extsprintf@1.3.0 None 0 22.8 kB dap
npm/fast-json-parse@1.0.3 None 0 6.91 kB matteo.collina
npm/forever-agent@0.6.1 network 0 14 kB simov
npm/fs-constants@1.0.0 filesystem 0 2.22 kB mafintosh
npm/gensync@1.0.0-beta.2 None 0 28.9 kB loganfsmyth
npm/get-package-type@0.1.0 filesystem 0 6.01 kB coreyfarrell
npm/graphemer@1.4.0 None 0 812 kB mattpauldavies
npm/har-schema@2.0.0 None 0 15.1 kB ahmadnassri
npm/has-flag@3.0.0 None 0 3.13 kB sindresorhus
npm/html-escaper@2.0.2 None 0 13.1 kB webreflection
npm/human-signals@2.1.0 None 0 44.3 kB ehmicky
npm/husky@8.0.3 environment, filesystem, shell 0 6.44 kB typicode
npm/ieee754@1.2.1 None 0 6.8 kB feross
npm/imurmurhash@0.1.4 None 0 11.9 kB jensyt
npm/ini@1.3.8 None 0 9.3 kB isaacs
npm/is-arrayish@0.2.1 None 0 4.05 kB qix
npm/is-extglob@2.1.1 None 0 6.22 kB jonschlinkert
npm/is-fullwidth-code-point@4.0.0 None 0 5.19 kB sindresorhus
npm/is-generator-fn@2.1.0 None 0 3.28 kB sindresorhus
npm/is-interactive@1.0.0 None 0 4.62 kB sindresorhus
npm/is-number@7.0.0 None 0 9.62 kB jonschlinkert
npm/is-obj@2.0.0 None 0 2.82 kB sindresorhus
npm/is-path-cwd@2.2.0 None 0 2.76 kB sindresorhus
npm/is-path-inside@3.0.3 None 0 4.12 kB sindresorhus
npm/is-typedarray@1.0.0 None 0 4.41 kB hughsk
npm/is-unicode-supported@0.1.0 None 0 3.54 kB sindresorhus
npm/is-windows@1.0.2 None 0 7.96 kB jonschlinkert
npm/isexe@2.0.0 environment, filesystem 0 11 kB isaacs
npm/isobject@3.0.1 None 0 6.93 kB doowb
npm/isstream@0.1.2 None 0 13.3 kB rvagg
npm/jest-get-type@29.6.3 None 0 3.79 kB simenb
npm/jest-regex-util@29.6.3 None 0 3.52 kB simenb
npm/jsbn@0.1.1 None 0 45.8 kB andyperlitch
npm/jsesc@2.5.2 None 0 32 kB mathias
npm/json-parse-better-errors@1.0.2 None 0 6.7 kB zkat
npm/json-schema-traverse@1.0.0 None 0 22.2 kB esp
npm/json-schema@0.4.0 None 0 26.1 kB kriszyp
npm/json-stable-stringify-without-jsonify@1.0.1 None 0 14.2 kB samn
npm/json-stringify-safe@5.0.1 None 0 12.7 kB isaacs
npm/json5@2.2.3 None 0 235 kB jordanbtucker
npm/kind-of@6.0.3 None 0 22.8 kB doowb
npm/kleur@3.0.3 None 0 9.89 kB lukeed
npm/lines-and-columns@1.2.4 None 0 5.39 kB eventualbuddha
npm/lodash.camelcase@4.3.0 None 0 21.9 kB jdalton
npm/lodash.debounce@4.0.8 None 0 14 kB jdalton
npm/lodash.defaults@4.2.0 None 0 21.1 kB jdalton
npm/lodash.difference@4.5.0 None 0 32.8 kB jdalton
npm/lodash.flatten@4.4.0 None 0 12.1 kB jdalton
npm/lodash.get@4.4.2 None 0 26.5 kB jdalton
npm/lodash.isplainobject@4.0.6 None 0 6.89 kB jdalton
npm/lodash.merge@4.6.2 None 0 54.1 kB jdalton
npm/lodash.union@4.6.0 None 0 32.5 kB jdalton
npm/make-error@1.3.6 None 0 12.4 kB julien-f
npm/merge2@1.4.1 None 0 8.9 kB zensh
npm/minimist@1.2.8 None 0 54.5 kB ljharb
npm/mute-stream@0.0.8 None 0 6.51 kB isaacs
npm/natural-compare-lite@1.4.0 None 0 5.63 kB lauriro
npm/natural-compare@1.4.0 None 0 5.65 kB megawac
npm/node-int64@0.4.0 None 0 16.3 kB broofa
npm/normalize-path@3.0.0 None 0 9.22 kB jonschlinkert
npm/oauth-sign@0.9.0 None 0 13.8 kB simov
npm/objectorarray@1.0.5 None 0 3.28 kB zhouhancheng
npm/obuf@1.1.2 None 0 19.1 kB indutny
npm/os-tmpdir@1.0.2 None 0 3.06 kB sindresorhus
npm/p-finally@1.0.0 None 0 3.11 kB sindresorhus
npm/p-try@2.2.0 None 0 4.37 kB sindresorhus
npm/path-exists@4.0.0 filesystem 0 3.92 kB sindresorhus
npm/path-key@3.1.1 None 0 4.55 kB sindresorhus
npm/path-parse@1.0.7 None 0 4.51 kB jbgutierrez
npm/path-type@4.0.0 filesystem 0 5.41 kB sindresorhus
npm/performance-now@2.1.0 None 0 11.3 kB meryn
npm/pg-int8@1.0.1 None 0 3.19 kB charmander
npm/pg-numeric@1.0.2 None 0 4.17 kB charmander
npm/picomatch@2.3.1 None 0 90 kB mrmlnc
npm/pify@4.0.1 None 0 7.23 kB sindresorhus
npm/pirates@4.0.6 unsafe 0 13.5 kB danez
npm/postgres-array@2.0.0 None 0 4.9 kB bendrucker
npm/postgres-bytea@1.0.0 None 0 3.06 kB bendrucker
npm/postgres-date@1.0.7 None 0 5.92 kB bendrucker
npm/prelude-ls@1.2.1 None 0 36.7 kB gkz
npm/process-nextick-args@2.0.1 None 0 3.17 kB cwmma
npm/psl@1.9.0 None 0 461 kB lupomontero
npm/queue-microtask@1.2.3 None 0 8.37 kB feross
npm/regenerate@1.4.2 None 0 49.2 kB mathias
npm/repeat-string@1.6.1 None 0 9.09 kB jonschlinkert
npm/require-from-string@2.0.2 unsafe 0 3.42 kB floatdrop
npm/resolve-from@5.0.0 filesystem, unsafe 0 5.82 kB sindresorhus
npm/resolve.exports@2.0.2 None 0 23.9 kB lukeed
npm/reusify@1.0.4 None 0 9.44 kB matteo.collina
npm/run-async@2.4.1 None 0 6.6 kB sboudrias
npm/safer-buffer@2.1.2 None 0 42.3 kB chalker
npm/sisteransi@1.0.5 None 0 6.79 kB terkelg
npm/slash@3.0.0 None 0 3.51 kB sindresorhus
npm/sprintf-js@1.0.3 None 0 34.8 kB alexei
npm/string-argv@0.3.2 None 0 7.8 kB cellule
npm/strip-bom@3.0.0 None 0 3 kB sindresorhus
npm/strip-final-newline@2.0.0 None 0 3.05 kB sindresorhus
npm/strip-json-comments@3.1.1 None 0 6.96 kB sindresorhus
npm/supports-preserve-symlinks-flag@1.0.0 None 0 9.18 kB ljharb
npm/through@2.3.8 None 0 12.5 kB dominictarr
npm/tinycolor2@1.6.0 None 0 285 kB bgrins
npm/tmpl@1.0.5 None 0 2.77 kB daaku
npm/to-fast-properties@2.0.0 None 0 3.5 kB sindresorhus
npm/tunnel@0.0.6 environment, network 0 64.9 kB koichik
npm/tweetnacl@0.14.5 None 0 174 kB dchest
npm/type-detect@4.0.8 None 0 42.1 kB chaijs
npm/type-fest@0.21.3 None 0 119 kB sindresorhus
npm/uglify-js@3.17.4 environment, eval, filesystem 0 1.28 MB alexlamsl
npm/unicode-canonical-property-names-ecmascript@2.0.0 None 0 5.01 kB google-wombot
npm/unicode-match-property-value-ecmascript@2.1.0 None 0 25.7 kB google-wombot
npm/unicode-property-aliases-ecmascript@2.1.0 None 0 5.98 kB google-wombot
npm/universalify@0.1.2 None 0 4.71 kB ryanzim
npm/util-deprecate@1.0.2 None 0 5.48 kB tootallnate
npm/v8-compile-cache-lib@3.0.1 environment, filesystem, unsafe 0 18.2 kB cspotcode
npm/wordwrap@1.0.0 None 0 36.8 kB substack
npm/xtend@4.0.2 None 0 6.46 kB raynos
npm/yallist@4.0.0 None 0 14.8 kB isaacs
npm/yaml@1.10.2 environment 0 448 kB eemeli
npm/yargs-parser@20.2.9 environment, filesystem 0 124 kB oss-bot
npm/yn@3.1.1 None 0 6.31 kB sindresorhus
npm/yocto-queue@0.1.0 None 0 6.03 kB sindresorhus

🚮 Removed packages: npm/@calcom/console@0.0.0-use.local, npm/@calcom/website@0.0.0-use.local, npm/@jridgewell/resolve-uri@3.1.2, npm/@jridgewell/set-array@1.2.1, npm/@jridgewell/sourcemap-codec@1.4.15, npm/@types/estree@1.0.5, npm/@types/json-schema@7.0.15, npm/@types/parse5@6.0.3, npm/@types/prop-types@15.7.12, npm/@types/trusted-types@2.0.7, npm/@webassemblyjs/floating-point-hex-parser@1.11.6, npm/@webassemblyjs/helper-api-error@1.11.6, npm/@webassemblyjs/helper-buffer@1.12.1, npm/@webassemblyjs/helper-wasm-bytecode@1.11.6, npm/@webassemblyjs/utf8@1.11.6, npm/@xtuc/ieee754@1.2.0, npm/@xtuc/long@4.2.2, npm/caniuse-lite@1.0.30001620, npm/chrome-trace-event@1.0.3, npm/csstype@3.1.3, npm/dotenv@16.4.5, npm/es-module-lexer@1.5.2, npm/escalade@3.1.2, npm/events@3.3.0, npm/function-bind@1.1.2, npm/functions-have-names@1.2.3, npm/glob-to-regexp@0.4.1, npm/graceful-fs@4.2.11, npm/has-bigints@1.0.2, npm/has-proto@1.0.3, npm/is-negative-zero@2.0.3, npm/isarray@2.0.5, npm/loader-runner@4.3.0, npm/node-releases@2.0.14, npm/object-inspect@1.13.1, npm/object-keys@1.1.1, npm/obliterator@1.6.1, npm/picocolors@1.0.1, npm/proxy-from-env@1.1.0, npm/punycode@2.3.1, npm/webpack-sources@3.2.3

View full report↗︎

@graphite-app Graphite App
Copy link

graphite-app bot commented May 17, 2024

Graphite Automations

"Add community label" took an action on this PR • (05/17/24)

1 label was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (05/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode added this to the v4.2 milestone May 20, 2024
@pellicceama
Copy link

came here to report this as well :)
image

@PeerRich
Copy link
Member

PeerRich commented Jun 3, 2024

i think this has been fixed

@PeerRich PeerRich closed this Jun 3, 2024
@dosubot dosubot bot removed this from the v4.2 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community Created by Linear-GitHub Sync i18n area: i18n, translations ui area: UI, frontend, button, form, input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@deepak-singh19 @CLAassistant @pellicceama @PeerRich @keithwillcode