chore: platform api usage based billing using queue #15085
Draft
+218
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
keithwillcode
added
core
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (05/16/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add platform team as reviewer" took an action on this PR • (05/16/24)1 reviewer was added to this PR based on Keith Williams's automation. |
dosubot
bot
added
the
bookings
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
…al.com into chore-platformapi-billing-queue
…alcom/cal.com into chore-platformapi-billing-queue
Current Playwright Test Results Summary✅ 321 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/18/2024 06:12:57am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 2f0fdf0 Started: 05/18/2024 06:10:46am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Reschedule for booking with seats If rescheduled/cancelled booking with seats it should display the correct number of seats
Retry 1 • Initial Attempt |
0% (0)0 / 212 runsfailed over last 7 days |
1.89% (4)4 / 212 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 2 • Retry 1 • Initial Attempt |
38.02% (92)92 / 242 runsfailed over last 7 days |
33.47% (81)81 / 242 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0.91% (2)2 / 219 runsfailed over last 7 days |
31.05% (68)68 / 219 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt |
4.48% (10)10 / 223 runsfailed over last 7 days |
19.28% (43)43 / 223 runsflaked over last 7 days |
📄 apps/web/playwright/managedBooking/advancedOptions.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Check advanced options in a managed team event type Check advanced options in a managed team event type without offer seats
Retry 1 • Initial Attempt |
0.45% (1)1 / 220 runfailed over last 7 days |
48.18% (106)106 / 220 runsflaked over last 7 days |
📄 apps/web/playwright/signup.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Signup Flow Test Email verification sent if enabled
Retry 1 • Initial Attempt |
0.85% (2)2 / 234 runsfailed over last 7 days |
25.64% (60)60 / 234 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1 • Initial Attempt |
0.46% (1)1 / 219 runfailed over last 7 days |
60.27% (132)132 / 219 runsflaked over last 7 days |
|
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1 • Initial Attempt |
0% (0)0 / 219 runsfailed over last 7 days |
63.01% (138)138 / 219 runsflaked over last 7 days |
|
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1 • Initial Attempt |
0.46% (1)1 / 219 runfailed over last 7 days |
60.27% (132)132 / 219 runsflaked over last 7 days |
|
Namespacing Different namespaces can have different init configs
Retry 1 • Initial Attempt |
0% (0)0 / 217 runsfailed over last 7 days |
60.37% (131)131 / 217 runsflaked over last 7 days |
📄 apps/web/playwright/hash-my-url.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
hash my url generate url hash
Retry 2 • Retry 1 • Initial Attempt |
5.96% (13)13 / 218 runsfailed over last 7 days |
27.98% (61)61 / 218 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- legacy Can create a booking for Round Robin EventType
Retry 2 • Retry 1 • Initial Attempt |
7.30% (17)17 / 233 runsfailed over last 7 days |
28.76% (67)67 / 233 runsflaked over last 7 days |
📄 apps/web/playwright/organization/booking.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Bookings Team Event Can create a booking for Round Robin EventType
Retry 2 • Retry 1 • Initial Attempt |
7.89% (18)18 / 228 runsfailed over last 7 days |
27.63% (63)63 / 228 runsflaked over last 7 days |
supalarry
requested changes
May 17, 2024
…b.com:calcom/cal.com into chore-platformapi-billing-queue
ThyMinimalDev
commented
May 17, 2024
| INCREMENT_JOB, | ||
| { | ||
| oAuthClientId: clientId, | ||
| } satisfies IncrementJobDataType, |
There was a problem hiding this comment.
I think we can skip using zod since we use satisfies here and this should be the only place we ever call the INCREMENT_JOB
|
Putting this back in draft until we have the proper discussion around Bull |
…al.com into chore-platformapi-billing-queue
|
need to change the logic to increment usage of managed user instead of relying on oauth client id , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Usage based billing for platform api using Bull Queue
if you are wondering why we don't simply tell stripe to decrement usage, it's simply because stripe does not allow it.