-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bookings made via API don't include the specified location #15067
base: main
Are you sure you want to change the base?
fix: bookings made via API don't include the specified location #15067
Conversation
Someone is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite Automations"Add community label" took an action on this PR • (05/16/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (05/16/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add platform team as reviewer" took an action on this PR • (05/16/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Loom Videos were commented out earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Shaik-Sirajuddin I have manually tested this and it works pretty well.
Do you think you could expand our tests to cover this edge case?
Off the top of my head fresh-booking.test.ts
will be the test fill that needs this edge case adding to
…https://github.com/Shaik-Sirajuddin/cal.com into fix_booking_made_via_api_notpicking_default_location
Hi @sean-brydon |
@@ -1287,7 +1287,7 @@ describe("handleNewBooking", () => { | |||
expectBookingCreatedWebhookToHaveBeenFired({ | |||
booker, | |||
organizer, | |||
location: OrganizerDefaultConferencingAppType, | |||
location: BookingLocations.CalVideo, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
webook responses contains exact location of booking
which is calvideo in this case
What does this PR do?
Before :
Fix #14341
Before : Loom
After : Loom
Fix #15059 :
Before : Loom
After : Loom
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist