[SPARK-48031] Decompose viewSchemaMode config, add SHOW CREATE TABLE support #46652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srielau
force-pushed
the
SPARK-48031-view-evolutiion-part2
branch
from
be6d238
to
ffa1fdb
Compare
srielau
force-pushed
the
SPARK-48031-view-evolutiion-part2
branch
from
ffa1fdb
to
da06989
Compare
cloud-fan
reviewed
May 20, 2024
cloud-fan
approved these changes
May 20, 2024
|
the last commit only updates the migration guide, no need to retest. merging to master! |
| .doc("Set to DISABLE to disable the WITH SCHEMA clause for view DDL and suppress the line in " + | ||
| " DESCRIBE EXTENDED. The default, and only other value, is COMPENSATION. Views without " + | ||
| " WITH SCHEMA clause are defaulted to WITH SCHEMA COMPENSATION.") | ||
| val VIEW_SCHEMA_BINDING_ENABLED = buildConf("spark.sql.legacy.viewSchemaBindingMode") |
There was a problem hiding this comment.
It is a bit weird that the boolean config name ends with Mode
| .booleanConf | ||
| .createWithDefault(true) | ||
|
|
||
| val VIEW_SCHEMA_COMPENSATION = buildConf("spark.sql.legacy.viewSchemaCompensation") |
There was a problem hiding this comment.
The COMPENSATION behavior should not be legacy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We separate enablement of WITH SCHEMA ... clause from the change in default from SCHEMA BINDING to SCHEMA COMPENSATION.
This allows user to upgrade in two steps:
Why are the changes needed?
It allows customers to upgrade more safely.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Added more tests
Was this patch authored or co-authored using generative AI tooling?
No