[SPARK-44838][SQL][FOLLOW-UP] Fix the test for raise_error by using default type for strings #46649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
commented
May 18, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
Outdated
Show resolved
Hide resolved
|
cc @cloud-fan and @uros-db |
|
For a bit of more context, the test fails as below: because it fails to add a cast from cc @gengliangwang too |
|
It was my understanding that this wouldn't be a problem, since this second parameter (MapType) is only used internally in Spark to raise errors |
|
@HyukjinKwon I believe you could just use: this would perhaps be a more uniform approach - it's what we usually do for various expressions (we offer support for AbstractMapType as well as AbstractArrayType) |
HyukjinKwon
force-pushed
the
SPARK-48162-followup
branch
from
0725ef9
to
0ad1a87
Compare
|
Sure, that sounds like more localized fix |
|
Seems like that still doesn't work with ANSI disabled: |
|
im gonna switch back to just fix ANSI disabeld type coercion rule but I think we should revisit those whole thing .. |
This reverts commit 0ad1a87.
cloud-fan
reviewed
May 20, 2024
| @@ -1048,6 +1048,9 @@ object TypeCoercion extends TypeCoercionBase { | |||
| } | |||
| } | |||
|
|
|||
| // Allows the cast between different collated strings to match with ANSI behavior. | |||
There was a problem hiding this comment.
This is a behavior change.
@uros-db I looked at the code base, we have implicit cast rules for AbstractArrayType, but not AbstractMapType, seems like a miss?
There was a problem hiding this comment.
AbstractMapType(StringTypeAnyCollation, StringTypeAnyCollation) does not work with non ANSI type coercion here. We should fix it here in any event.
There was a problem hiding this comment.
@uros-db please open a separate PR - I can close mine.
|
Gentle ping, @uros-db . The CI is still broken. |
|
fix should be ready #46661 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #46461 that fixes the CI failure when ANSI is off:
Why are the changes needed?
CI is broken https://github.com/apache/spark/actions/runs/9136253329
Does this PR introduce any user-facing change?
No, the main change has not been released out.
How was this patch tested?
Manually ran the test with ANSI disabled.
Was this patch authored or co-authored using generative AI tooling?
No.