[SPARK-48255][BUILD] Guava should not respect hadoop.deps.scope
#46556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR changes the guava's scope in
assembly/pom.xmlfrom${hadoop.deps.scope}tocompile.Why are the changes needed?
Guava is not a Hadoop dependency now.
Historically, Spark depends on the Hadoop vanilla client and hence pulls all Hadoop transitive deps, and Guava is one of those. While in SPARK-33212, Spark moved to Hadoop Shaded client for Hadoop3, and in SPARK-42452, Spark dropped support for Hadoop2.
Additionally, Hadoop moved to
hadoop-shaded-guavain HADOOP-17288Does this PR introduce any user-facing change?
No.
How was this patch tested?
Review.
Was this patch authored or co-authored using generative AI tooling?
No.