Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default sql for RQL #31229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix default sql for RQL #31229

wants to merge 1 commit into from

Conversation

caorong
Copy link

@caorong caorong commented May 15, 2024

Fixes #ISSUSE_ID.

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

Copy link
Contributor

@RaigorJiang RaigorJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @caorong , Please update both Chinese(cn) and English(en) documents

@H-Jason
Copy link

H-Jason commented May 19, 2024

hello,why does my pull request can not pass all check,The CI check failed. I just change one line,and it show "
CI / CI - Compile by JDK 11 and Run on JDK 8 (pull_request) "; My pull request just submit before you; my pull request of sharding

@RaigorJiang
Copy link
Contributor

hello,why does my pull request can not pass all check,The CI check failed. I just change one line,and it show " CI / CI - Compile by JDK 11 and Run on JDK 8 (pull_request) "; My pull request just submit before you; my pull request of sharding

Hi @H-Jason , I found some errors in your PR:

image

@H-Jason
Copy link

H-Jason commented May 20, 2024

hello,why does my pull request can not pass all check,The CI check failed. I just change one line,and it show " CI / CI - Compile by JDK 11 and Run on JDK 8 (pull_request) "; My pull request just submit before you; my pull request of sharding

Hi @H-Jason , I found some errors in your PR:
image

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants