Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt: when the table name is sql keyword #30868

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZmingZinnia
Copy link

@ZmingZinnia ZmingZinnia commented Apr 12, 2024

Fixes #30867.

Changes proposed in this pull request:

adopted unstandardized table name. avoid null point error

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@@ -53,7 +53,7 @@
@RequiredArgsConstructor
public final class MySQLComFieldListPacketExecutor implements CommandExecutor {

private static final String SQL = "SHOW COLUMNS FROM %s FROM %s";
private static final String SQL = "SHOW COLUMNS FROM `%s` FROM %s";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

null point error when the table name is unstandardized
2 participants