-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
修复 TradeOrderUpdateService 的单元测试 #525
base: master-jdk17
Are you sure you want to change the base?
修复 TradeOrderUpdateService 的单元测试 #525
Conversation
@@ -20,7 +21,7 @@ public class DeliveryExpressDO extends BaseDO { | |||
/** | |||
* 编号,自增 | |||
*/ | |||
@TableId | |||
@TableId(type = IdType.AUTO) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
要 @TableId,不然多 DB 无法兼容
|
||
@BeforeEach | ||
public void setUp() { | ||
when(tradeOrderProperties.getAppId()).thenReturn(888L); | ||
when(tradeOrderProperties.getPayExpireTime()).thenReturn(Duration.ofDays(1)); | ||
when(tradeNoRedisDAO.generate(anyString())).thenReturn(UUID.randomUUID().toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以使用 IdUtil 的 simpleUUID 替代
@@ -322,7 +322,7 @@ public class TradeOrderDO extends BaseDO { | |||
* | |||
* 关联 CombinationRecordDO 的 headId 字段 | |||
*/ | |||
private Long combinationHeadId; | |||
private Long combinationHeadId; // FIXME 2024/5/15: "团长" 应该译作 leader / starter 而不是 head |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
head 和 leader 都有哈。
这块先暂时不改,涉及的地方太多了。
已经第一轮 review,等待修改 |
No description provided.