fix NPE on MainActivity#onClick (reported on Telegram)

VishnuSanal · Aug 20, 2023 · acdb79d · acdb79d
1 parent e69077c
commit acdb79d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/app/src/main/java/phone/vishnu/quotes/activity/MainActivity.java b/app/src/main/java/phone/vishnu/quotes/activity/MainActivity.java
@@ -176,7 +176,9 @@ public void onClick(View v) {
                         .add(
                                 R.id.constraintLayout,
                                 CustomiseFragment.newInstance(
-                                        allQuotesList.get(viewPager.getCurrentItem())),
+                                        allQuotesList != null
+                                                ? allQuotesList.get(viewPager.getCurrentItem())
+                                                : Utils.Companion.getSampleQuote()),
                                 null)
                         .addToBackStack(null)
                         .commit();

diff --git a/app/src/main/java/phone/vishnu/quotes/helper/Utils.kt b/app/src/main/java/phone/vishnu/quotes/helper/Utils.kt
@@ -22,12 +22,18 @@ package phone.vishnu.quotes.helper
 import android.content.Context
 import android.content.res.Resources
 import android.util.DisplayMetrics
+import phone.vishnu.quotes.model.Quote
 import kotlin.math.roundToInt
 
 class Utils {
 
 	companion object {
 
+		val sampleQuote: Quote = Quote(
+			"Twenty years from now you will be more disappointed by the things that you didn’t do than by the ones you did do, so throw off the bowlines, sail away from safe harbor, catch the trade winds in your sails.  Explore, Dream, Discover",
+			"Mark Twain",
+		)
+
 		fun DPtoPX(context: Context, DP: Int): Int {
 			return (DP * (context.resources.displayMetrics.xdpi / DisplayMetrics.DENSITY_DEFAULT)).roundToInt()
 		}