Handling and propagation of UART errors #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add return code to UART TX function to be able to detect transmit errors and propagate this information to higher layers.
UART RX callback functions return status codes, but they were never checked in the library code. Handle failures of UART RC callbacks and propagate them to higher layers.
This prevents infinite blocking when BT chip is not present or is not responding to the commands. Usually, functions check for pending data using UART peek callback first, but in some cases data is just awaited (sl_bt_wait_response, sli_bgapi_get_event), causing infinite blocking when BT chip is not present or not responding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UART callback functions (except TX) already returned status codes, but they were never checked, resulting in blocking states in case of UART errors.
This PR adds return code to UART TX function and actually handles return codes of all UART callbacks, and optional time callback to prevent infinite blocking in case there is no UART I/O error, but the application error.