Plex webhook episode detection for non-episode videos #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cazzar
reviewed
May 12, 2024
| .Where(a => a.EpisodeTypeEnum == episodeType) | ||
| .Where(a => a.Title.Equals(metadata.Title)) | ||
| .Where(a => a.AniDB_Episode.EpisodeNumber == episodeNumber | ||
| || (a.TvDBEpisode?.SeasonNumber == series && a.TvDBEpisode?.EpisodeNumber == episodeNumber)).ToList(); |
There was a problem hiding this comment.
Not a huge fan of this - the reason is doing this "a or b" could cause erroneous matches.
| var nameMatches = anime | ||
| .GetAnimeEpisodes().Where(a => a.AniDB_Episode != null) | ||
| .Where(a => a.EpisodeTypeEnum == episodeType) | ||
| .Where(a => a.Title.Equals(metadata.Title)) |
There was a problem hiding this comment.
What about the situation where a user changes the episode title?
Use title + episode number (or TVDB season + episode #) for non-Episode type videos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use title + episode number (or TVDB season + episode #) for non-Episode type videos.Use Plex API to fetch the filename of the watched video file (for non-episode type videos).
This should allow the Plex webhook to mark specials and other video types as watched.
There is a corner case where the user has multiple episodes with the same file name in a series, handling that is TBD.