[16.0][ADD] web_calendar_slot_duration_by_user #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you check this PR too ? Context : In some cases, an employee will plan by default meets each hour. But another employee (in another department) will plan his meets each 30min. |
yajo
requested changes
Jun 5, 2024
Comment on lines
+10
to
+15
| use_custom_calendar = fields.Boolean( | ||
| help="If checked, the user will use the custom calendar", | ||
| ) | ||
| slot_duration = fields.Char( | ||
| help="The slot duration for the user", | ||
| ) |
There was a problem hiding this comment.
I think you can just set a default slot duration for everybody and remove the boolean field.
Also the duration should be IMHO a Float using the float_time widget for better UI consistency.
| <field name="use_custom_calendar" /> | ||
| <field | ||
| name="slot_duration" | ||
| help="Duration of the default duration for the calendar view in the format HH:MM:SS" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.