Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [mig] hr_timesheet_sheet_policy_department_manager #678

Conversation

edlopen
Copy link
Member

@edlopen edlopen commented May 17, 2024

Migration to 16.0 with some changes to the tests.

@moduon MT-1703

@yajo @EmilioPascual @Shide @rafaelbn @fcvalgar review this PR when you can. Thank you!

alexey-pelykh and others added 20 commits May 15, 2024 11:31
Currently translated at 100.0% (9 of 9 strings)

Translation: timesheet-12.0/timesheet-12.0-hr_timesheet_sheet_policy_department_manager
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_timesheet_sheet_policy_department_manager/es/
Currently translated at 100.0% (9 of 9 strings)

Translation: timesheet-12.0/timesheet-12.0-hr_timesheet_sheet_policy_department_manager
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_timesheet_sheet_policy_department_manager/es/
Currently translated at 100.0% (11 of 11 strings)

Translation: timesheet-12.0/timesheet-12.0-hr_timesheet_sheet_policy_department_manager
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_timesheet_sheet_policy_department_manager/fr/
Currently translated at 100.0% (9 of 9 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet_policy_department_manager
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet_policy_department_manager/it/
Currently translated at 100.0% (9 of 9 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet_policy_department_manager
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet_policy_department_manager/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet_policy_department_manager
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet_policy_department_manager/
Currently translated at 100.0% (9 of 9 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet_policy_department_manager
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet_policy_department_manager/it/
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review.

LGTM, Thank you @edlopen

image

image

image

Copy link

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Functional and code review
Nice job @edlopen

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@alexey-pelykh
Copy link
Contributor

/ocabot migration hr_timesheet_sheet_policy_department_manager

@alexey-pelykh
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 30, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 30, 2024
15 tasks
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-678-by-alexey-pelykh-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f801dc2 into OCA:16.0 May 30, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 772abbb. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 16.0-mig-hr_timesheet_sheet_policy_department_manager branch May 31, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet