Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] stock_barcodes: Migration to 16.0 #610

Open
wants to merge 202 commits into
base: 16.0
Choose a base branch
from

Conversation

chienandalu
Copy link
Member

Followup to #587

  • Drop scan read logs feature, which use was deprecated already in the
    previous versions.
  • Pass bootstrap migration scripts.
  • Fix views issues.
  • Other code fixes.

cc @Tecnativa

@FranzPoize I've been doing the migration with @sergio-teruel, who's the main developer of the module in the spanish OCA days. We started from your migration head.

At this point the module is completely functional, although we're still tweaking the views to fit the previous state.

@pedrobaeza
Copy link
Member

This doesn't contain #604

@pedrobaeza
Copy link
Member

/ocabot migration stock_barcodes

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 13, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 13, 2024
8 tasks
sergio-teruel and others added 25 commits May 13, 2024 10:38
When user creates a lot, set default product the wizard selected product.
When confirm the lot creation wizard, set this lot in lot wizard scanning barcode field.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-11.0/stock-logistics-barcode-11.0-stock_barcodes
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-11-0/stock-logistics-barcode-11-0-stock_barcodes/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-stock_barcodes
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-stock_barcodes/
When we've got an out picking, the logical workflow is that the scanned location
is the location we're getting the stock from
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-stock_barcodes
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-stock_barcodes/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-13.0/stock-logistics-barcode-13.0-stock_barcodes
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-13-0/stock-logistics-barcode-13-0-stock_barcodes/
oca-ci and others added 4 commits May 13, 2024 10:38
@chienandalu
Copy link
Member Author

This doesn't contain #604

Fixed

@FranzPoize
Copy link

FranzPoize commented May 13, 2024

Hello ! I pushed some stuff just after you created this PR I think. In it there was a lot of work to replace the always_reload feature of old odoo version.

@chienandalu
Copy link
Member Author

Hi, @FranzPoize !

Do you mean this new stuff or something else?: 3828828#diff-f69121127ec9ebdc28296fa3a7f3760d71865de0267308101bf6d467fef4769cR106-R121

@FranzPoize
Copy link

No I mean this stuff 3828828#diff-00871f58b13dd92c5ff7599bc210323e9a6e64bdbf58abd5a3c19c83428d5dbb

What you linked to is some other features we added:

  • Allowing scanning product on at a time in new picking (not use the total quant by default)
  • Forbidding picking validation if their is a move_line with the same location_id and location_dest_id
  • Offer an option to not check demand during picking (this solve the issue where if you reload after a picking creation you will not be able to pick more product without using the force action done)
  • Update all destination of all move_line when scanning a location (This allows destination to be scanned last because otherwise it does not work)

@chienandalu
Copy link
Member Author

there was a lot of work to replace the always_reload feature of old odoo version.
I mean this stuff 3828828#diff-00871f58b13dd92c5ff7599bc210323e9a6e64bdbf58abd5a3c19c83428d5dbb

Can you elaborate on why this is needed? What's the issue you're trying to solve?

other features we added:

  • Allowing scanning product on at a time in new picking (not use the total quant by default)
  • Forbidding picking validation if their is a move_line with the same location_id and location_dest_id
  • Offer an option to not check demand during picking (this solve the issue where if you reload after a picking creation you will not be able to pick more product without using the force action done)
  • Update all destination of all move_line when scanning a location (This allows destination to be scanned last because otherwise it does not work)

I commented these with @sergio-teruel last week and some of them could be accomplished with the current config (I'm sure he can elaborate in detail :)). In any case, is better to limit the scope the PR to the module migration stuff and do any feature proposal in a later one

@FranzPoize
Copy link

You don't have to take those features if you don't want to. But you should take the always_reload feature imho because otherwise there is no update of many2one field unless there is a button pressed.

sergio-teruel and others added 6 commits May 15, 2024 12:15
- Drop scan read logs feature, which use was deprecated already in the
  previous versions.
- Pass bootstrap migration scripts.
- Fix views issues.
- Other code fixes.
@FranzPoize
Copy link

In 14.0 there was this

options="{'no_open': True, 'always_reload': True}"
This does not work anymore the code here 3828828#diff-00871f58b13dd92c5ff7599bc210323e9a6e64bdbf58abd5a3c19c83428d5dbb replaces this always_reload feature.

And I said many2ones in my previous comment I made a mistake. This allows one2many fields and many2many field to update their data when an onchange event is triggered.

@chienandalu
Copy link
Member Author

Hi @FranzPoize let me check it and I tell you

@lk-eska
Copy link

lk-eska commented May 27, 2024

Is there any progress on this PR?

@sergio-teruel
Copy link

Hi @ik-eska two commits 4 days ago... Any progress?? Yes...

@lk-eska
Copy link

lk-eska commented May 27, 2024

Sorry @sergio-teruel I haven't noticed them.

@sergio-teruel
Copy link

jaja... don't worry... 😄

@sergio-teruel
Copy link

Cherry pick from 15.0 ef65da1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet