product_multi_barcode: remove useless costly dependency #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When having a product with a lot of variant if you try to remove some product.attribute.value it will remove the related product.product and everytime a product.product is remove this will trigger the computed field On my db removing a product.product take 10s without this change and 3s after A test have been added to check that this change to not have impact when creating a product_template with a barcode
|
Thanks ! Please take a look on precommit. |
rousseldenis
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
LGTM. @sebastienbeau Could you rebase as soon as #577 is merged?
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having a product with a lot of variant
if you try to remove some product.attribute.value
it will remove the related product.product
and everytime a product.product is remove
this will trigger the computed field
On my db removing a product.product take 10s without this change and 3s after
A test have been added to check that this change to not have impact when creating a product_template with a barcode
@Kev-Roche