-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] product_packaging_multi_barcode_stock_menu: view packaging on barcode list #541
base: 16.0
Are you sure you want to change the base?
[16.0][ADD] product_packaging_multi_barcode_stock_menu: view packaging on barcode list #541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot do that, product.barcode.packaging_id
field is part of product_packaging_multi_barcode
module, so this doesn't respect the inheritance.
@sebalix Should I make |
@santostelmo no we cannot do that neither sadly. I think the way it has been designed, we have to create a In the long term, as both product and packaging are part of Odoo std ( cc @simahawk |
0a3565e
to
06f1912
Compare
@sebalix I have created the module |
0fa8585
to
30cd8b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, would like to hear another opinion about this though, as I do not know these modules a lot
Ping @santostelmo , Could you help to fix this? |
30cd8b2
to
cc0f210
Compare
@QuocDuong1306 I fixed the points mentioned above. @sebalix could you please check your change requests ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, can you add (in a separate commit) a ROADMAP.rst entry in product_packaging_multi_barcode
module to merge it in product_multi_barcode
for the next migration, and same for product_packaging_multi_barcode_stock_menu
+ product_multi_barcode_stock_menu
to merge them in a new module product_multi_barcode_stock
.
At the end we'll get only two modules, one depending exclusively on product
, the other one being a glue module extending the first by adding a dependency on stock
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an expert but LGTM
2c4ec04
to
5b37b16
Compare
5b37b16
to
13fefcf
Compare
Show
packaging
field in product barcode tree view