[16.0][MIG] product_supplierinfo_barcode #446

tewtawat · 2022-10-10T13:58:37Z

Standard Migration

Add barcode field to supplier pricelis items (supplier info), so that it can used to search product by supplier barcodes.

…ier codes

Currently translated at 100.0% (5 of 5 strings) Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-product_supplierinfo_barcode Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-product_supplierinfo_barcode/de/

oca-clabot · 2022-10-10T13:58:40Z

Hey @tewtawat, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

oca-ci oca-ci@odoo-community.org (no github login found)

Appreciation of efforts,
OCA CLAbot

rousseldenis · 2022-10-10T14:04:34Z

@tewtawat Thanks for this. Could you just add in the description the dependency PR link in order to easy review? Thanks

tewtawat · 2022-10-10T14:36:53Z

@rousseldenis okay but there're no dependency pr for this module. what should i have to do

rousseldenis · 2022-10-10T14:39:15Z

@rousseldenis okay but there're no dependency pr for this module. what should i have to do

Ok, sorry. 😅

rousseldenis · 2022-10-10T14:39:28Z

/ocabot migration product_supplierinfo_barcode

rousseldenis

Code review

marylla

I did a functional review.

I can only set the barcode for a supplier info in its form view when using this menu: purchase > configuration > vendor pricelists.

Unfortunately, it is not possible to add this barcode in product form view in page "purchase" because the tree view for supplier info has a "edit" option to edit it inline and not open a form view.

I think, we should add the barcode field also in supplier info tree view.

marylla

Weirdly it worked now for me too. :) So everything fine now.

enriquemartin · 2023-05-03T14:33:18Z

product_supplierinfo_barcode/views/product_views.xml

+                />
+            </field>
+        </field>
+    </record>


Why not migrate the view that adds the barcode to the supllierinfo tree in the product form?
Like in version 15:

stock-logistics-barcode/product_supplierinfo_barcode/views/product_views.xml

Lines 18 to 27 in 147a302

<record id="product_supplierinfo_tree_view2" model="ir.ui.view">

<field name="name">product.supplierinfo.tree.view2.barcode</field>

<field name="model">product.supplierinfo</field>

<field name="inherit_id" ref="purchase.product_supplierinfo_tree_view2" />

<field name="arch" type="xml">

<field name="product_code" position="after">

<field name="barcode" optional="hide" />

</field>

</field>

</record>

Tested in local environment and works correctly.

rousseldenis · 2023-07-11T12:01:30Z

/ocabot rebase

OCA-git-bot · 2023-07-11T12:01:37Z

@rousseldenis The rebase process failed, because command git push --force trinityroots tmp-pr-446:16.0-mig-product_supplierinfo_barcode failed with output:

remote: Permission to trinityroots/stock-logistics-barcode.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/trinityroots/stock-logistics-barcode/': The requested URL returned error: 403

github-actions · 2023-11-12T12:11:34Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

hildickethan-S73 · 2023-11-13T14:37:39Z

@tewtawat could you rebase the branch? to fix any conflict before merge as it seems like the bot had issues doing that

github-actions · 2024-03-24T12:12:33Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

OCA-git-bot · 2024-03-29T20:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza

And check the other existing comment

pedrobaeza · 2024-03-30T09:29:24Z

product_supplierinfo_barcode/__manifest__.py

+    "preloadable": True,
+    "depends": [
+        # we need purchase to view seller_ids in product form
+        "purchase",


Is this still applicable?

pedrobaeza · 2024-03-30T09:31:01Z

product_supplierinfo_barcode/models/supplierinfo.py

+    _sql_constraints = [
+        (
+            "barcode_uniq",
+            "unique(barcode)",


I think this constraint is too restrictive, as several suppliers may have the same barcode. It should be a combination of unique company, seller and barcode

eLBati and others added 17 commits October 10, 2022 20:54

ADD product_supplierinfo_barcode:

e59c8ad

Add barcode field to supplier pricelis items (supplier info), so that it can used to search product by supplier barcodes.

[UPD] Update product_supplierinfo_barcode.pot

6d2eb38

[UPD] README.rst

6778dc7

[ADD] icon.png

7787060

IMP product_supplierinfo_barcode allowing to search products by suppl…

ec99c1d

…ier codes

[UPD] Update product_supplierinfo_barcode.pot

c7d7c93

product_supplierinfo_barcode 12.0.1.1.0

fdac1ed

Added translation using Weblate (German)

95d8c00

[IMP] product_supplierinfo_barcode: black, isort, prettier

b97b8b8

[MIG] product_supplierinfo_barcode: Migration to 14.0

7f6cd44

[UPD] Update product_supplierinfo_barcode.pot

0db259b

[UPD] README.rst

c4b78d1

[MIG] product_supplierinfo_barcode: Migration to 15.0

f08a1a6

[UPD] Update product_supplierinfo_barcode.pot

b12a007

[UPD] README.rst

a5b9874

[IMP] product_supplierinfo_barcode: pre-commit stuff

0ba8602

[16.0][MIG] product_supplierinfo_barcode

2148995

OCA-git-bot added this to the 16.0 milestone Oct 10, 2022

OCA-git-bot mentioned this pull request Oct 10, 2022

Migration to version 16.0 #440

Open

8 tasks

rousseldenis added needs review migration labels Oct 10, 2022

rousseldenis approved these changes Oct 10, 2022

View reviewed changes

marylla suggested changes Oct 25, 2022

View reviewed changes

This comment was marked as duplicate.

Sign in to view

marylla approved these changes Feb 23, 2023

View reviewed changes

OCA-git-bot added the approved label Feb 23, 2023

enriquemartin reviewed May 3, 2023

View reviewed changes

enriquemartin mentioned this pull request May 3, 2023

[16.0][MIG] product_multi_barcode_supplierinfo: migration to 16.0 #509

Closed

hildickethan-S73 approved these changes Jul 11, 2023

View reviewed changes

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 12, 2023

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 19, 2023

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 24, 2024

OCA-git-bot added the ready to merge label Mar 29, 2024

pedrobaeza requested changes Mar 30, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Mar 30, 2024

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] product_supplierinfo_barcode #446

[16.0][MIG] product_supplierinfo_barcode #446

tewtawat commented Oct 10, 2022

oca-clabot commented Oct 10, 2022

rousseldenis commented Oct 10, 2022 •

edited

tewtawat commented Oct 10, 2022

rousseldenis commented Oct 10, 2022

rousseldenis commented Oct 10, 2022

rousseldenis left a comment

marylla left a comment

This comment was marked as duplicate.

marylla left a comment

enriquemartin May 3, 2023

rousseldenis commented Jul 11, 2023

OCA-git-bot commented Jul 11, 2023

github-actions bot commented Nov 12, 2023

hildickethan-S73 commented Nov 13, 2023

github-actions bot commented Mar 24, 2024

OCA-git-bot commented Mar 29, 2024

pedrobaeza left a comment

pedrobaeza Mar 30, 2024

pedrobaeza Mar 30, 2024

	<record id="product_supplierinfo_tree_view2" model="ir.ui.view">
	<field name="name">product.supplierinfo.tree.view2.barcode</field>
	<field name="model">product.supplierinfo</field>
	<field name="inherit_id" ref="purchase.product_supplierinfo_tree_view2" />
	<field name="arch" type="xml">
	<field name="product_code" position="after">
	<field name="barcode" optional="hide" />
	</field>
	</field>
	</record>

[16.0][MIG] product_supplierinfo_barcode #446

Are you sure you want to change the base?

[16.0][MIG] product_supplierinfo_barcode #446

Conversation

tewtawat commented Oct 10, 2022

oca-clabot commented Oct 10, 2022

rousseldenis commented Oct 10, 2022 • edited

tewtawat commented Oct 10, 2022

rousseldenis commented Oct 10, 2022

rousseldenis commented Oct 10, 2022

rousseldenis left a comment

Choose a reason for hiding this comment

marylla left a comment

Choose a reason for hiding this comment

This comment was marked as duplicate.

marylla left a comment

Choose a reason for hiding this comment

enriquemartin May 3, 2023

Choose a reason for hiding this comment

rousseldenis commented Jul 11, 2023

OCA-git-bot commented Jul 11, 2023

github-actions bot commented Nov 12, 2023

hildickethan-S73 commented Nov 13, 2023

github-actions bot commented Mar 24, 2024

OCA-git-bot commented Mar 29, 2024

pedrobaeza left a comment

Choose a reason for hiding this comment

pedrobaeza Mar 30, 2024

Choose a reason for hiding this comment

pedrobaeza Mar 30, 2024

Choose a reason for hiding this comment

rousseldenis commented Oct 10, 2022 •

edited