Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] auto_backup: do not fail if directory exists #2939

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][FIX] auto_backup: do not fail if directory exists #2939

wants to merge 1 commit into from

Conversation

NL66278
Copy link
Contributor

@NL66278 NL66278 commented May 11, 2024

No description provided.

@NL66278 NL66278 mentioned this pull request May 11, 2024
Merged
SirAionTech
SirAionTech suggested changes May 28, 2024
View reviewed changes
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Only code review

auto_backup/models/db_backup.py Outdated Show resolved Hide resolved
auto_backup/tests/test_db_backup.py Outdated Show resolved Hide resolved
@NL66278
Copy link
Contributor Author

NL66278 commented May 28, 2024

@SirAionTech Thank you for your review and suggestions. I limited the fix to the local back-up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirAionTech SirAionTech SirAionTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NL66278 @SirAionTech