Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] auto_backup: Migration to 17.0 #2894

Open
wants to merge 60 commits into
base: 17.0
Choose a base branch
from

Conversation

rpinset
Copy link
Member

@rpinset rpinset commented Mar 31, 2024

No description provided.

Yenthe666 and others added 30 commits March 31, 2024 14:05
Added all the new fields and sentences. This will be the template for
translations.
Used to open  fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure.
- Follow template README.
- Remove HTML README.
- Move models to models folder.
- Model and view file names follow guidelines.
- Unused methods cleanup.
- Remove unneeded `.pot` file.
- Fix permissons.
- Follow PEP8 in names everywhere.
- Set more descriptive field names.
- Disable backups for other databases, for security.
- Remove db name from generated file, for easier cleanup.
- EAFP logic everywhere.
- More descriptive name.
- Data files moved to YAML, with cleaner ir.cron record creation.
- Add permissions for db.backup model.
- Icons.
- Update tests with new format.
- Storage method is a selectable, for easier extensibility.
- Instead of custom mailing, it just has a mail thread where you can subscribe.
- Should fix almost all comments in OCA#203.
- Reduce headers.

This respects the upstream license choice (GPL/AGPL) but reduces
verbosity.

It would be ideal to have everything under AGPL though.
* Add self.ensure_ones
* Add test coverage
* [10.0][auto_backup] Menu entry moved

* Update version in manifest
Currently translated at 58.2% (32 of 55 strings)

Translation: server-tools-11.0/server-tools-11.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-11-0/server-tools-11-0-auto_backup/nl/
Added test coverage
Added requirements.txt for pysftp
Added in the roadmap the exact version of pysftp for this to work (0.2.8)
Added in the roadmap the problem with list_db=False
Adapted calls to message_post
Currently translated at 17.5% (14 of 80 strings)

Translation: server-tools-12.0/server-tools-12.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/pt_BR/
Currently translated at 26.2% (21 of 80 strings)

Translation: server-tools-12.0/server-tools-12.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/
Currently translated at 100.0% (80 of 80 strings)

Translation: server-tools-12.0/server-tools-12.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/
Currently translated at 100.0% (80 of 80 strings)

Translation: server-tools-12.0/server-tools-12.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/
Currently translated at 100.0% (80 of 80 strings)

Translation: server-tools-12.0/server-tools-12.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/
Currently translated at 51.2% (41 of 80 strings)

Translation: server-tools-12.0/server-tools-12.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/hr/
Currently translated at 80.2% (69 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
anhvu-sg and others added 21 commits March 31, 2024 14:05
Currently translated at 100.0% (86 of 86 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/es_AR/
Currently translated at 86.0% (74 of 86 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
Currently translated at 86.0% (74 of 86 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
Currently translated at 86.0% (74 of 86 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/
Currently translated at 100.0% (80 of 80 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/es_AR/
Currently translated at 90.0% (72 of 80 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
Currently translated at 90.0% (72 of 80 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
Currently translated at 84.7% (72 of 85 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
Currently translated at 100.0% (85 of 85 strings)

Translation: server-tools-16.0/server-tools-16.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-auto_backup/es/
Currently translated at 87.0% (74 of 85 strings)

Translation: server-tools-16.0/server-tools-16.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-auto_backup/it/
Currently translated at 100.0% (85 of 85 strings)

Translation: server-tools-16.0/server-tools-16.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-auto_backup/it/
Currently translated at 100.0% (85 of 85 strings)

Translation: server-tools-16.0/server-tools-16.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-auto_backup/it/
Currently translated at 100.0% (85 of 85 strings)

Translation: server-tools-16.0/server-tools-16.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-auto_backup/it/
@OCA-git-bot
Copy link
Contributor

Hi @sebastienbeau, @hparfr,
some modules you are maintaining are being modified, check this out!

@rpinset
Copy link
Member Author

rpinset commented Mar 31, 2024

@rvalyi I followed the wiki though https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#how-to

these are my only modifications
rpinset@b5eb35a

Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you solve the pre-commit issues?
You can also squash translation commits of the same person & language:
image

@rpinset
Copy link
Member Author

rpinset commented Apr 15, 2024

Could you solve the pre-commit issues? You can also squash translation commits of the same person & language: image

Sorry @CRogos, but this is my first attempt to push a migration.
I don't know how to use pre-commit.
I followed the wiki though https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#how-to
these are my only modifications
rpinset@b5eb35a
and cafb66f

@CRogos
Copy link
Contributor

CRogos commented Apr 16, 2024

Yes I also struggled a lot with my first migration.
pre-commit is a tool to automate certain things like code formatting. in this case, one issue is the xml formatting.
But instead of changing it manually you should install pre-commit on your dev environment.
https://github.com/OCA/maintainer-tools/wiki/Install-pre-commit
image

To squash certain commits, you find the instructions here:
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

in short the most important commands are:
git config --global --add rebase.instructionFormat "(%an <%ae>) %s"
git rebase -i origin/17.0
# change "pick" by "f" where needed and commit the changes
git push -f

giovannigd pushed a commit to ingegniamo/server-tools-mig that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet