-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [ADD] purchase_sign #2270
Conversation
ea44ce6
to
8a6a3e6
Compare
@rafaelbn , @yajo , @EmilioPascual , can you please review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ByteMeAsap for your work.
I've test module in runboat but I can't get it to work.
I have made a purchase order with a supplier using a portal user.
But no purchase order is displayed on the portal.
Also, does it make sense for suppliers to access a portal to confirm their sales? Normally it would be the other way around, the buyer would have to access the supplier's platform.
Perhaps you could add context to the pr by commenting on the situation in which this flow could be used.
@EmilioPascual , only the RFQs in sent state would show up under Request for Quotation(as that's how its setted up in Odoo base). Once the RFQ is sent (by email) to the vendor, it would show up on the portal.
Yes, it does make sense in certain scenarios , for example we can define our rates for products to be purchased and ask suppliers for confirming the same or add their feedback through the communication section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the great work @ByteMeAsap
This PR has the |
@rafaelbn , @yajo , @EmilioPascual , can we have this merged? |
pre-commit fixes Test fixes Removed unwanted check Removed unwanted check for access Reverted changes and updated test scripts pre-commit fix test fix test fix Test comment changes Added tests Removed commit
8a6a3e6
to
ad61699
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
On my way to merge this fine PR! |
This PR has the |
@rafaelbn , @yajo , @EmilioPascual , can we please have this merged? |
Congratulations, your PR was merged at 6ef683a. Thanks a lot for contributing to OCA. ❤️ |
This module allows to take online signatures from vendors to confirm purchase orders similar to how it is currently for sale orders.