Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [ADD] purchase_sign #2270

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

ByteMeAsap
Copy link
Contributor

This module allows to take online signatures from vendors to confirm purchase orders similar to how it is currently for sale orders.

@ByteMeAsap ByteMeAsap force-pushed the 16.0-add-purchase_sign branch 10 times, most recently from ea44ce6 to 8a6a3e6 Compare May 8, 2024 11:02
@ByteMeAsap
Copy link
Contributor Author

@rafaelbn , @yajo , @EmilioPascual , can you please review this

Copy link
Contributor

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ByteMeAsap for your work.
I've test module in runboat but I can't get it to work.
I have made a purchase order with a supplier using a portal user.
image
But no purchase order is displayed on the portal.
image
Also, does it make sense for suppliers to access a portal to confirm their sales? Normally it would be the other way around, the buyer would have to access the supplier's platform.
Perhaps you could add context to the pr by commenting on the situation in which this flow could be used.

@ByteMeAsap
Copy link
Contributor Author

ByteMeAsap commented May 16, 2024

But no purchase order is displayed on the portal.

@EmilioPascual , only the RFQs in sent state would show up under Request for Quotation(as that's how its setted up in Odoo base). Once the RFQ is sent (by email) to the vendor, it would show up on the portal.

Also, does it make sense for suppliers to access a portal to confirm their sales?

Yes, it does make sense in certain scenarios , for example we can define our rates for products to be purchased and ask suppliers for confirming the same or add their feedback through the communication section.

Copy link

@Jan-Onestein Jan-Onestein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the great work @ByteMeAsap

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ByteMeAsap
Copy link
Contributor Author

@rafaelbn , @yajo , @EmilioPascual , can we have this merged?

purchase_sign/controllers/main.py Outdated Show resolved Hide resolved
pre-commit fixes

Test fixes

Removed unwanted check

Removed unwanted check for access

Reverted changes and updated test scripts

pre-commit fix

test fix

test fix

Test comment changes

Added tests

Removed commit
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2270-by-yajo-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Jan-Onestein
Copy link

@rafaelbn , @yajo , @EmilioPascual , can we please have this merged?

@OCA-git-bot OCA-git-bot merged commit 781c00a into OCA:16.0 Jun 11, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6ef683a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants