[14.0][ADD] purchase_order_sending_warning #2269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaniszewska-dev
force-pushed
the
purchase_order_send_warn
branch
4 times, most recently
from
6c5a978
to
6496aa4
Compare
ajaniszewska-dev
commented
May 7, 2024
ajaniszewska-dev
force-pushed
the
purchase_order_send_warn
branch
3 times, most recently
from
b4e8016
to
c0d2309
Compare
ajaniszewska-dev
force-pushed
the
purchase_order_send_warn
branch
from
c0d2309
to
00f7459
Compare
florentx
reviewed
May 14, 2024
Comment on lines
10
to
16
| sending_warning = fields.Selection(selection=[("email_not_sent", "Email not sent")]) | ||
|
|
||
| error_in_sending = fields.Boolean( | ||
| store=True, | ||
| compute="_compute_error_in_sending", | ||
| string="Error in sending", | ||
| ) |
There was a problem hiding this comment.
I wonder if we need 2 fields here. Maybe the Selection field is enough.
For the name of the field, I would prefer transmission_error or sending_error since it is more important than a warning.
There was a problem hiding this comment.
@florentx 2 fields are there because selection is going to be extended (for example by edi) and user would like to know POs which failed (whatever they failed - edi or email), so computed field will be set whenever mail/edi sending fails. I'll rename.
ajaniszewska-dev
force-pushed
the
purchase_order_send_warn
branch
2 times, most recently
from
35e3b6a
to
4fb6ee4
Compare
ajaniszewska-dev
force-pushed
the
purchase_order_send_warn
branch
from
4fb6ee4
to
1ddcfff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.