[17.0] [MIG] supplier_calendar: Migration to 17.0 #2264
Merged
+1,103
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix pre-commit errors by addind the correct `website` key
Currently translated at 100.0% (8 of 8 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-supplier_calendar Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-supplier_calendar/it/
Currently translated at 100.0% (8 of 8 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-supplier_calendar Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-supplier_calendar/es/
when delta argument is a float `plan_days` method can return unexpected False result. This can lead to silent errors. Therefore we ensure that delta is a integer in the helper.
Comment on lines
34
to
35
| if isinstance(delta, float): | ||
| delta = round(delta) |
There was a problem hiding this comment.
Thanks @HviorForgeFlow
Those lines are on purpose and need to be there. (ref: #2255)
Please @bizzappdev do not remove it
There was a problem hiding this comment.
I added it back. @LoisRForgeFlow
bizzappdev
force-pushed
the
17.0-mig-supplier_calendar-BAD
branch
from
c907c18
to
6afecfd
Compare
PCatinean
approved these changes
May 29, 2024
HviorForgeFlow
approved these changes
May 29, 2024
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at c10d5eb. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.