[17.0][MIG] purchase_order_approved #2262

MarioLM-23 · 2024-05-02T10:33:25Z

Standar migration with changes in old references

Currently translated at 100.0% (9 of 9 strings) Translation: purchase-workflow-11.0/purchase-workflow-11.0-purchase_order_approved Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-11-0/purchase-workflow-11-0-purchase_order_approved/nl_NL/

Currently translated at 100.0% (29 of 29 strings) Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_approved Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_approved/zh_CN/

Currently translated at 10.3% (3 of 29 strings) Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_approved Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_approved/pt_BR/

…d state

…al workflow by supplier

Currently translated at 9.0% (3 of 33 strings) Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_order_approved Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_order_approved/pt_BR/

…chase' state In core module, service products can be received by editing the received quantity on 'purchase' order state. This restablishes that behaviour

Currently translated at 6.6% (2 of 30 strings) Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_order_approved Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_order_approved/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_approved Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_approved/

Currently translated at 90.0% (27 of 30 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_approved Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_approved/fr/

Currently translated at 63.3% (19 of 30 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_approved Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_approved/pt_BR/

Currently translated at 93.3% (28 of 30 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_approved Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_approved/pt_BR/

Currently translated at 100.0% (30 of 30 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_approved Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_approved/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_approved Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_approved/

Currently translated at 100.0% (30 of 30 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_approved Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_approved/it/

Currently translated at 100.0% (30 of 30 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_approved Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_approved/pt_BR/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_approved Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_approved/

Currently translated at 100.0% (30 of 30 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_approved Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_approved/it/

Currently translated at 100.0% (30 of 30 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_approved Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_approved/es/

ChristianSantamaria

Tested, code review:
purchase_exception addon was added by mistake

Minor changes in views:

ChristianSantamaria · 2024-05-08T15:32:21Z

purchase_order_approved/views/purchase_order_view.xml

+                    name="readonly"
+                >state in ['cancel', 'to approve', 'approved']</attribute>


Suggested change

name="readonly"

>state in ['cancel', 'to approve', 'approved']</attribute>

name="invisible"

>state not in ['cancel', 'to approve', 'approved']</attribute>

ChristianSantamaria · 2024-05-08T15:32:42Z

purchase_order_approved/views/purchase_order_view.xml

+                    name="readonly"
+                >state in ['draft', 'to approve', 'approved', 'sent', 'purchase']</attribute>


Suggested change

name="readonly"

>state in ['draft', 'to approve', 'approved', 'sent', 'purchase']</attribute>

name="invisible"

>state not in ['draft', 'to approve', 'approved', 'sent', 'purchase']</attribute>

ChristianSantamaria · 2024-05-08T15:33:22Z

purchase_order_approved/views/purchase_order_view.xml

+                <button
+                    name="button_release"
+                    type="object"
+                    readonly="state in ['approved']"


Suggested change

readonly="state in ['approved']"

invisible="state != 'approved'"

MarioLM-23 · 2024-05-08T16:07:28Z

Tested, code review: purchase_exception addon was added by mistake

Minor changes in views:

Done, What should I do to fix the addon error? Then I will change the commit description
Thank you for the review

ChristianSantamaria · 2024-05-08T16:27:57Z

@mariobinhex, I understand that you are working on two addons at the same time and these changes were inadvertently sneaked in.

, you could revert the three files by hand or position yourself in the previous commit and not add the settings in the three files so that later only the approve addon uploads

MarioLM-23 · 2024-05-10T13:01:23Z

@ChristianSantamaria Hello and thanks for the explanation I have already made the changes

LoisRForgeFlow and others added 30 commits May 2, 2024 09:26

[9.0][ADD] purchase_order_approved

1cd1888

OCA Transbot updated translations from Transifex

9d8bd34

[10.0][MIG] purcahse_order_approved

37a964f

improve performance

a5f7134

[11.0][MIG] purchase_order_approved

833305d

[11.0] purchase_order_approved: fix image link in readme

5c830b0

[MIG] purchase_order_approved: Migration to 12.0

955dd23

[12.0][FIX] purchase_order_approved

1259760

purchase_order_approved 12.0.1.0.1

eb4bcb4

[IMP] purchase_order_approved: black, isort

f04e562

[MIG] purchase_order_approved: Migration to 13.0

5ffea1e

[UPD] Eficent -> ForgeFlow

a239318

[MIG] purchase_order_approved: Migration to 14.0

20779d0

[14.0][IMP] purchase_order_approved: add approved orders filter

03a9a94

[14.0][IMP] purchase_order_approved: allow purchase cancel on approve…

93d42dc

…d state

purchase_order_approved 14.0.1.1.0

6175182

[IMP] purchase_order_approved: Allows to activate the two-step approv…

7744997

…al workflow by supplier

purchase_order_approved 14.0.1.2.0

fdf4928

[FIX] purchase_order_approved: Allow to receive products when in 'Pur…

c3c541e

…chase' state In core module, service products can be received by editing the received quantity on 'purchase' order state. This restablishes that behaviour

purchase_order_approved 14.0.1.2.1

f619ef8

[IMP] purchase_order_approved: black, isort, prettier

6c3130c

[MIG] purchase_order_approved: Migration to 15.0

3e6fb1c

[MIG] purchase_order_approved: Migration to 16.0

8ef2926

[UPD] Update purchase_order_approved.pot

de84a7c

[UPD] README.rst

4700239

weblate and others added 13 commits May 2, 2024 09:26

[UPD] README.rst

ebab154

[UPD] Update purchase_order_approved.pot

0f11e71

MarioLM-23 mentioned this pull request May 2, 2024

Migration to version 17.0 #2087

Open

42 tasks

MarioLM-23 force-pushed the 17.0-mig-purchase_order_approved branch from b80f4c2 to e410804 Compare May 6, 2024 08:25

ChristianSantamaria suggested changes May 8, 2024

View reviewed changes

MarioLM-23 force-pushed the 17.0-mig-purchase_order_approved branch from e410804 to 9dc2d40 Compare May 8, 2024 16:02

MarioLM-23 force-pushed the 17.0-mig-purchase_order_approved branch from 9dc2d40 to f908e8a Compare May 10, 2024 11:19

Mario Luis Mora added 2 commits May 10, 2024 13:36

[IMP] purchase_order_approved: pre-commit auto fixes

433abcd

[MIG] purchase_order_approved: Migration to 17.0

1751d75

MarioLM-23 force-pushed the 17.0-mig-purchase_order_approved branch from f908e8a to 1751d75 Compare May 10, 2024 12:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] purchase_order_approved #2262

[17.0][MIG] purchase_order_approved #2262

MarioLM-23 commented May 2, 2024

ChristianSantamaria left a comment

ChristianSantamaria May 8, 2024

ChristianSantamaria May 8, 2024

ChristianSantamaria May 8, 2024

MarioLM-23 commented May 8, 2024

ChristianSantamaria commented May 8, 2024

MarioLM-23 commented May 10, 2024

		name="readonly"
		>state in ['cancel', 'to approve', 'approved']</attribute>

		name="readonly"
		>state in ['draft', 'to approve', 'approved', 'sent', 'purchase']</attribute>

	readonly="state in ['approved']"
	invisible="state != 'approved'"

[17.0][MIG] purchase_order_approved #2262

Are you sure you want to change the base?

[17.0][MIG] purchase_order_approved #2262

Conversation

MarioLM-23 commented May 2, 2024

ChristianSantamaria left a comment

Choose a reason for hiding this comment

ChristianSantamaria May 8, 2024

Choose a reason for hiding this comment

ChristianSantamaria May 8, 2024

Choose a reason for hiding this comment

ChristianSantamaria May 8, 2024

Choose a reason for hiding this comment

MarioLM-23 commented May 8, 2024

ChristianSantamaria commented May 8, 2024

MarioLM-23 commented May 10, 2024