[14.0][FIX] project_milestone : Wrong assignment of tasks to milestones when duplicating a project #1283 #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es when duplicating a project OCA#1283
|
Hi @patrickrwilson, |
|
@OCA/project-maintainers : Here is a fix for issue #1283 |
abenzbiria
changed the title
aleuffre
approved these changes
May 27, 2024
There was a problem hiding this comment.
Code review, LGTM.
I wonder if there's a more robust way of finding the milestone instead of using the name. Maybe instead of copy=True the milestones could be copied "manually" inside the copy function, in order to have a mapping between old and new milestones.
| milestone = project.milestone_ids.filtered( | ||
| lambda milestone: "2" not in milestone.name | ||
| ) | ||
| assert tasks[0].milestone_id == milestone and tasks[1].milestone_id == milestone |
There was a problem hiding this comment.
chore (non-blocking): would prefer the usage of self.assertTrue or similar instead of the raw assert
|
@OCA/project-service-maintainers : Thank you for your review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #1283