Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] project_task_parent_filter: Recover create option in "My Tasks" tree view #1281

Merged
merged 1 commit into from
Jun 7, 2024
Merged

[16.0][FIX] project_task_parent_filter: Recover create option in "My Tasks" tree view #1281

merged 1 commit into from
Jun 7, 2024

Conversation

mariancuadranetkia
Copy link

Recover create option in "My tasks" tree view.

@pedrobaeza pedrobaeza added this to the 16.0 milestone May 15, 2024
@pedrobaeza
Copy link
Member

Thanks for this, Marián. Please follow commit message guidelines: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

@pedrobaeza
Copy link
Member

@JordiBForgeFlow this was removed by María in c976574. Do you know why?

@mariancuadranetkia
Copy link
Author

Thanks @pedrobaeza for your answer. Is it recomendable I change commit message and push it again? Or is not necessary?
I'll try to do it better next time.
About views: in kanban view, it's possible create new task but not in tree view (in My tasks). For this, we are not sure about reasons to disable create option and we propose to recover it.

@pedrobaeza
Copy link
Member

Yes, please reformat the commit message

@mariancuadranetkia mariancuadranetkia force-pushed the 16.0-project-task-parent-filter-fix-view-treecreate branch from 14c6c4a to 0a638d2 Compare May 22, 2024 09:36
@mariancuadranetkia mariancuadranetkia force-pushed the 16.0-project-task-parent-filter-fix-view-treecreate branch from 0a638d2 to 1a6d6ae Compare May 30, 2024 08:23
HaraldPanten
HaraldPanten approved these changes May 30, 2024
View reviewed changes
Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariancuadranetkia
Copy link
Author

@pedrobaeza I have reformatted the commit message, is it ok?
Thanks!

hugomartineznetkia
hugomartineznetkia approved these changes Jun 7, 2024
View reviewed changes
Copy link

@hugomartineznetkia hugomartineznetkia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1281-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ff83169 into OCA:16.0 Jun 7, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e35d41f. Thanks a lot for contributing to OCA. ❤️

@mariancuadranetkia mariancuadranetkia deleted the 16.0-project-task-parent-filter-fix-view-treecreate branch June 7, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@hugomartineznetkia hugomartineznetkia hugomartineznetkia approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mariancuadranetkia @pedrobaeza @OCA-git-bot @HaraldPanten @hugomartineznetkia