Skip to content

Commit

Permalink
[FIX] website: stop showing CSS variable assertion tour step to users
Browse files Browse the repository at this point in the history
Commit [1] introduced a website tour util to assert the value of a CSS
variable. This was used at the start of theme tours to check we are in
fact on the right theme before starting the tour.

While it's great for those tours when they are started as a test, it was
not meant to be shown to users following that tour. This commit fixes
that. Notice that theme tours are currently broken so the issue was
probably hidden. Those will be fixed at [2].

[1]: odoo@b29e177
[2]: odoo#106703

Related to task-3084175

closes odoo#106725

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
  • Loading branch information
qsm-odoo committed Nov 28, 2022
1 parent 101d83d commit 696c45b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions addons/website/static/src/js/tours/tour_utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ function assertCssVariable(variableName, variableValue, trigger = 'iframe body')
return {
content: `Check CSS variable ${variableName}=${variableValue}`,
trigger: trigger,
auto: true,
run: function () {
const styleValue = getComputedStyle(this.$anchor[0]).getPropertyValue(variableName);
if ((styleValue && styleValue.trim()) !== variableValue.trim()) {
Expand Down

0 comments on commit 696c45b

Please sign in to comment.