Skip to content

Commit

Permalink
[FIX] portal: fix portal title for the salesperson data
Browse files Browse the repository at this point in the history
Before this commit, if the helpdesk module was installed, the title of
the salesperson data was changed from "Your contact" to "Salesperson"
for portal users. This did not add any value and the title of the tab
also became "Salesperson" which we do not want. This commit allows to
keep the title "Your contact" above the salesperson information and to
not change the tab title.

Steps to reproduce the problem fixed by this commit:
- Run Odoo enterprise with helpdesk and sales installed.
- As the admin, create a helpdesk ticket with Joel Willis (portal user)
as the customer and save.
- Click on Joel Willis, select the "Sales & Purchases" tab and set a
salesperson.

=> Log in as Joel Willis and on /my, you will have "Salesperson" as the
title of the tab. This bad behavior is due to [this commit] that added a
title above the salesperson information. But with this change the title
of the tab was also impacted. Then [this other commit] added a default
title above the salesperson information. We can be satisfied with this
default title which does not alter the title of the tab.

[this commit]: odoo/enterprise@700e9de
[this other commit]: odoo@d5c66ca

opw-3103718

closes odoo#108705

Related: odoo/enterprise#35240
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
  • Loading branch information
Guillaume-gdi authored and qsm-odoo committed Jan 4, 2023
1 parent 336b966 commit 1ebeec9
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions addons/portal/views/portal_templates.xml
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,11 @@
</div>
</template>

<!--
TODO adapt in master: remove the use of the "title" variable in this
template (or rename the variable). Using it at controller level actually
also controls the browser tab title, which makes no sense.
-->
<template id="portal_contact" name="Contact">
<div class="o_portal_contact_details mb-5">
<h4><t t-if="title" t-esc="title"/><t t-else="">Your contact</t></h4>
Expand Down

0 comments on commit 1ebeec9

Please sign in to comment.