Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add miruro website support to malsync #2396

Merged
merged 6 commits into from
May 21, 2024

Conversation

Debjoy
Copy link
Contributor

@Debjoy Debjoy commented May 11, 2024

PR for adding https://www.miruro.tv and https://www.miruro.online tracking support in MALSync.

src/pages/Miruro/main.ts Outdated Show resolved Hide resolved
src/pages/Miruro/main.ts Show resolved Hide resolved
src/pages/Miruro/main.ts Show resolved Hide resolved
src/pages/Miruro/main.ts Outdated Show resolved Hide resolved
src/pages/Miruro/main.ts Outdated Show resolved Hide resolved
src/pages/Miruro/tests.json Show resolved Hide resolved
@Debjoy Debjoy requested a review from lolamtisch May 16, 2024 07:53
@lolamtisch
Copy link
Member

@Debjoy Could you give my changes a test?

@lolamtisch lolamtisch merged commit 2db7677 into MALSync:master May 21, 2024
6 checks passed
@Debjoy
Copy link
Contributor Author

Debjoy commented May 21, 2024

@Debjoy Could you give my changes a test?

Hi I apologies for the delay in response due to time zones. Thank you for taking the time to do the modifications 🙇 I have tested your changes. Everything is working except when I'm loading the video player (sync) page directly. (eg: https://www.miruro.tv/watch/153288/kaijuu-8-gou/6 )At that time UI isn't loading 🤔
Its working when I'm loading the website and navigating to the page or i'm changing to a different episode without reloading the page (urlChangeDetect runs at that time)
I'll create a new merge request to keep things clean.
Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants