New Page AnimesOnline #2392
Merged
New Page AnimesOnline #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolamtisch
requested changes
May 14, 2024
src/pages/AnimesOnline/main.ts
Outdated
Comment on lines
38
to
43
| getTitle(url) { | ||
| return j.$(j.$('.breadcrumb li')[2]).text().replace('- Dublado', '').trim(); | ||
| }, | ||
| getIdentifier(url) { | ||
| return j.$(j.$('.breadcrumb li')[2]).text().trim().replace('- Dublado', ''); | ||
| }, |
There was a problem hiding this comment.
duplicated code. One could just call return AnimesOnline.sync.getTitle(url);
src/pages/AnimesOnline/main.ts
Outdated
Comment on lines
55
to
60
| getTitle(url) { | ||
| return j.$(j.$('.breadcrumb li')[2]).text().replace('- Dublado', '').trim(); | ||
| }, | ||
| getIdentifier(url) { | ||
| return j.$(j.$('.breadcrumb li')[2]).text().replace('- Dublado', '').trim(); | ||
| }, |
There was a problem hiding this comment.
More duplicated code. You can just call the functions of the sync section
src/pages/AnimesOnline/main.ts
Outdated
|
|
||
| export const AnimesOnline: pageInterface = { | ||
| name: 'Animes Online', | ||
| domain: 'animesonline.in', |
There was a problem hiding this comment.
Please use https://animesonline.in
src/pages/AnimesOnline/main.ts
Outdated
|
|
||
| if (tempSrc === undefined) { | ||
| if (currentTries >= 100) { | ||
| alert('MAL-SYNC: Cant find target src video, please refresh the page and try again!'); |
There was a problem hiding this comment.
Alerts are a bit hard. Please use
utils.flashm(`MAL-SYNC: Cant find target src video, please refresh the page and try again!`, {
error: true,
type: 'error',
});
|
Requested changes done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new page animesonline