Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: folder inheritance scripts #7430

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented May 17, 2024

todo

  • add tab and edit pane
  • wire up
  • test

closes INS-3860

challenges

  • how to wrap each level of script in such a way they don't affect the promises or the variables scopes of others

@jackkav jackkav changed the title supprt scripts in folder scope support scripts in folder scope May 17, 2024
@jackkav jackkav changed the title support scripts in folder scope feat: folder inheritance - support scripts May 17, 2024
@jackkav jackkav changed the title feat: folder inheritance - support scripts feat: folder inheritance scripts May 17, 2024
@jackkav jackkav marked this pull request as ready for review May 22, 2024 12:51
@jackkav jackkav force-pushed the feat/script-inheritance branch 2 times, most recently from 9fc4ebd to 375aef1 Compare June 5, 2024 03:16
@jackkav jackkav requested a review from a team June 5, 2024 04:04
@@ -451,18 +451,6 @@ test.describe('unhappy paths', async () => {
});

const testCases = [
{
Copy link
Contributor

@ihexxa ihexxa Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah we might bring back this case.

@gatzjames gatzjames merged commit 80ab8b0 into Kong:develop Jun 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants