Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grep: fix broken links in gnuman directory #171808

Merged
merged 2 commits into from
May 16, 2024

Conversation

mnencia
Copy link
Contributor

@mnencia mnencia commented May 15, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The fgrep and egrep commands have been deprecated since 2007 and the
related manpages have been removed in 2021. See commit
https://git.savannah.gnu.org/cgit/grep.git/commit/?id=a951562
in the grep source repository.

This patch stops creating broken links for fgrep.1 and egrep.1
manpages in the libexec/gnuman/man1 directory.

Formula/g/grep.rb Outdated Show resolved Hide resolved
The fgrep and egrep commands have been deprecated since 2007 and the
related manpages have been removed in 2021. See commit
https://git.savannah.gnu.org/cgit/grep.git/commit/?id=a951562
in the grep source repository.

This patch stops creating broken links for fgrep.1 and egrep.1
manpages in the libexec/gnuman/man1 directory.

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@mnencia
Copy link
Contributor Author

mnencia commented May 16, 2024

It looks like the tests failed due to a network timeout. Can you try running them again?

@carlocab carlocab added the CI-skip-dependents Pass --skip-dependents to brew test-bot. label May 16, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 16, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 16, 2024
Merged via the queue into Homebrew:master with commit d6d6906 May 16, 2024
14 checks passed
@mnencia mnencia deleted the grep_man_fix branch May 17, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-dependents Pass --skip-dependents to brew test-bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants