Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request 2985] Custom username editor #3309

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Feature Request 2985] Custom username editor #3309

wants to merge 2 commits into from

Conversation

edonaHajredinaj
Copy link

Adds Feature Request 2985, Added a custom username editor so that users can hide their username if someone looks at their phone screen.

@TacoTheDank
Copy link
Member

@edonaHajredinaj Just a few nitpicks I have: please make openDialog private and rename it to fakenameDialog, and also replace .equals("") with .isEmpty(). Other than that, it looks good. Thank you very much for your contribution! :)

@TacoTheDank TacoTheDank linked an issue Dec 13, 2020 that may be closed by this pull request
[Feature Request]: Username Hider/Replacer #2985
Open
@TacoTheDank
Copy link
Member

@edonaHajredinaj Any updates?

@TacoTheDank
Copy link
Member

Guess I'll do it myself then...

@edonaHajredinaj

This comment has been minimized.

Sign in to view
@TacoTheDank
Copy link
Member

@edonaHajredinaj No worries, I've already done it :)

Alexendoo
Alexendoo requested changes Jan 10, 2021
View reviewed changes
Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just some R.string.* changes needed (allows them to be translated into different languages)

app/src/main/java/me/ccrama/redditslide/Activities/MainActivity.java Show resolved Hide resolved
app/src/main/java/me/ccrama/redditslide/Activities/MainActivity.java Show resolved Hide resolved
app/src/main/java/me/ccrama/redditslide/Activities/MainActivity.java Show resolved Hide resolved
@ccrama
Copy link
Collaborator

ccrama commented Jan 19, 2021

I've updated the string resources, we should use the AlertDialogWrapper for better theming of this popup

This was referenced Jul 8, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexendoo Alexendoo Alexendoo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Username Hider/Replacer
4 participants
@edonaHajredinaj @TacoTheDank @ccrama @Alexendoo