Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 3026: auto-copy URL for old devices #3162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

goforbg
Copy link

@goforbg goforbg commented May 4, 2020

Fixes #3026 : Copying URL support for old devices when showing share Intent

Didn't inflate a new item in the Bottom sheet, instead invoked auto-copy URL for older devices support.

@Alexendoo
Copy link
Member

I'm not sure it's a good idea to overwrite the users clipboard without a clear indication that's what they expect to happen

@goforbg
Copy link
Author

goforbg commented May 4, 2020

Fair enough, looking forward to implement any suggestions for this fix

@tobiscode
Copy link

Is this related to #3430?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add copy url of post or comment to clipboard directly not via Android share
3 participants