Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multireddit dropdown list in drawer #3066

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Multireddit dropdown list in drawer #3066

wants to merge 2 commits into from

Conversation

philippTheCat
Copy link

No description provided.

Alexendoo
Alexendoo requested changes Sep 9, 2019
View reviewed changes
Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Particular thanks for being brave enough to touch MainActivity

app/src/main/java/me/ccrama/redditslide/Activities/MainActivity.java Outdated Show resolved Hide resolved
app/src/main/java/me/ccrama/redditslide/Activities/MainActivity.java Outdated Show resolved Hide resolved
app/src/main/res/layout/drawer_loggedin.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/drawer_loggedin.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/drawer_loggedin.xml Outdated Show resolved Hide resolved
app/src/main/java/me/ccrama/redditslide/Activities/MainActivity.java Outdated Show resolved Hide resolved
app/src/main/res/layout/multireddit_textview_white.xml Show resolved Hide resolved
Alexendoo
Alexendoo requested changes Sep 18, 2019
View reviewed changes
app/src/main/java/me/ccrama/redditslide/Activities/MainActivity.java
headerMain = header;
hea = header.findViewById(R.id.back);

drawerSubList.addHeaderView(header, null, false);
((TextView) header.findViewById(R.id.name)).setText(Authentication.name);
header.findViewById(R.id.multi).setOnClickListener(new OnSingleClickListener() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this removed it's not possible to open the regular MultiredditOverview

Alexendoo
Alexendoo reviewed Sep 18, 2019
View reviewed changes
Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A final appearance thing, but you might also want to hide the dropdown if the user doesn't have any multireddits, since it still toggles but nothing appears underneath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexendoo Alexendoo Alexendoo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philippTheCat @Alexendoo