Support for loading mp4 variant of i.reddit gifs #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And some cleanup
* Add share link and copy link to ShareLinkBottomSheetFragment for gif variants
Docile-Alligator
force-pushed
the
master
branch
from
9a532f9
to
94f08d6
Compare
|
Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more waiting for 50-100mb gifs to load. Particularly useful for subreddits like r/educationalgifs
Works with galleries.
Works with captions.
Works with autoplay if it's not a gallery (still works if you open the gallery).
You can download the original gif should you please, through a three dot menu (also present on Bottom Toolbar).
I opted for hiding playback controls for gifs inside galleries to make room for captions (it's also what the official app does), maybe we can do it differently.
Maybe closes #515