Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename FragmentStateAdapter usages #1014

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename FragmentStateAdapter usages #1014

wants to merge 1 commit into from

Conversation

TacoTheDank
Copy link
Contributor

They were all named the same, so I renamed them to be specific to each activity.

@Docile-Alligator
Copy link
Owner

Thank you. But why?

@TacoTheDank
Copy link
Contributor Author

TacoTheDank commented Oct 10, 2022 •
edited

Because they all had the same name, which is quite confusing.

Also, they were no longer pagerAdapters, but stateAdapters. Keeping them named as pagerAdapters would also be confusing.

@Wladefant
Copy link
Collaborator

Yes that is understandable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Docile-Alligator Docile-Alligator Awaiting requested review from Docile-Alligator

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TacoTheDank @Docile-Alligator @Wladefant