Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OperationState enum should be an extensible union #851

Conversation

weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented May 17, 2024

Need to use union signifying open enum.

fix #584

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 17, 2024

All changed packages have been documented.

  • @azure-tools/typespec-azure-core
Show changes

@azure-tools/typespec-azure-core - fix ✏️

Convert OperationState enum to an open union

@azure-sdk
Copy link
Collaborator

@timotheeguerin timotheeguerin marked this pull request as ready for review May 20, 2024 18:39
@timotheeguerin timotheeguerin changed the title typespec-azure-core, use union for OperationState OperationState enum should be an extensible union May 20, 2024
@timotheeguerin timotheeguerin added this pull request to the merge queue May 21, 2024
Merged via the queue into Azure:main with commit e2bb305 May 21, 2024
21 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the typespec-azure-core_union-for-open-enum branch May 22, 2024 01:25
@weidongxu-microsoft weidongxu-microsoft restored the typespec-azure-core_union-for-open-enum branch May 22, 2024 01:25
@weidongxu-microsoft weidongxu-microsoft deleted the typespec-azure-core_union-for-open-enum branch May 22, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: typespec-azure-resource-manager and typespec-azure-core still uses enum
4 participants